Set client_name metadata #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkinkade
approved these changes
Jan 24, 2024
app/measure/measure.js
Outdated
| downloadworkerfile: "/libraries/ndt7-download-worker.min.js" | ||
| downloadworkerfile: "/libraries/ndt7-download-worker.min.js", | ||
| metadata: { | ||
| client_name: "mlab-speedtest", |
There was a problem hiding this comment.
To be more definitive, could we change this to "speed.measurementlab.net" or "speed-measurementlab-net"? I'm just wondering if "mlab-speedtest" might be too generic, in the case that we may launch some other speed test, like msak, at some other domain or location.
|
Visit the preview URL for this PR (updated for commit fc6ad12): https://mlab-speedtest--pr64-sandbox-roberto-add-hw5q8359.web.app (expires Wed, 31 Jan 2024 18:08:45 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f345dd84eac1914fdbf22d41db69d580917840b9 |
nkinkade
approved these changes
Jan 24, 2024
This was referenced Feb 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests coming from speed.measurementlab.net don't currently set
client_name, thus we cannot easily know how much traffic we get from there. This change should fix that.EDIT: This change turned out being a much larger change. The authentication method we used (tokens) to deploy to Firebase is deprecated and does not work anymore. I moved the deployment of this repo to Github Actions.