Always return results in Mb/s #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pboothe
reviewed
Jan 31, 2019
app/measure/measure.js
Outdated
| } else if (currentPhase == PHASE_DOWNLOAD) { | ||
| $scope.currentPhase = gettextCatalog.getString('Download'); | ||
| $scope.currentSpeed = downloadSpeedVal ? getJustfiedSpeed(downloadSpeedVal) + ' ' + getSpeedUnit(downloadSpeedVal) : gettextCatalog.getString('Initializing'); | ||
| $scope.currentSpeed = downloadSpeedVal ? getJustfiedSpeed(downloadSpeedVal) + ' Mb/s' : gettextCatalog.getString('Initializing'); |
There was a problem hiding this comment.
getJustifiedSpeed() is the wrong thing to use if you want to fix units in Mb/s. I suggest rewriting it to always return the speed in Mb/s plus at most two decimal points.
There was a problem hiding this comment.
@pboothe: This should be fixed now. PTAL?
|
Please also delete the functions LGTM |
pboothe
approved these changes
Feb 1, 2019
…). Everything is now in Mb/s.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix issue #6 in which speed result units may be incorrectly reported.