Skip to content

Commit

Permalink
Updates container image versions for external-dns and kubeip deployme…
Browse files Browse the repository at this point in the history
…nts (#851)

* Updates repo and version for external-dns deployment

* Updates version for kubeip deployment

* Sets strategy to Recreate for kubeip deployment

When you only have a single replica in a deployment, a rolling update
doesn't always make the most sense, especially if the service isn't user
facing. This change sets the update strategy for the kubeip deployment
to a simple "Recreate", which will just delete the old pod and create a
new one.

* Moves kubeip deployment to kube-system namespace

* Moves kubeip SA to kube-system namespace
  • Loading branch information
nkinkade authored Nov 12, 2021
1 parent 0d96caf commit b4a01fd
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
2 changes: 1 addition & 1 deletion k8s/prometheus-federation/deployments/external-dns.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ spec:
serviceAccountName: external-dns
containers:
- name: external-dns
image: registry.opensource.zalan.do/teapot/external-dns:v0.5.17
image: k8s.gcr.io/external-dns/external-dns:v0.10.1
# domain-filter is the zone we want to manage. txt-owner-id is an
# arbitrary identifier used to track who created each entry (scoped
# here to the cluster, in case we end up using more than one
Expand Down
6 changes: 4 additions & 2 deletions k8s/prometheus-federation/deployments/kubeip.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,14 @@ apiVersion: apps/v1
kind: Deployment
metadata:
name: kubeip
namespace: default
namespace: kube-system
spec:
replicas: 1
selector:
matchLabels:
app: kubeip
strategy:
type: Recreate
template:
metadata:
labels:
Expand All @@ -16,7 +18,7 @@ spec:
priorityClassName: system-cluster-critical
containers:
- name: "kubeip"
image: doitintl/kubeip:issue-34
image: doitintl/kubeip:v1.0.0
imagePullPolicy: Always
volumeMounts:
- name: google-cloud-key
Expand Down
2 changes: 2 additions & 0 deletions k8s/prometheus-federation/roles/rbac-kubeip.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,14 @@ apiVersion: v1
kind: ServiceAccount
metadata:
name: kubeip
namespace: kube-system
---
# Allow kubeIP to keep an eye on nodes and pods
kind: ClusterRole
apiVersion: rbac.authorization.k8s.io/v1
metadata:
name: kubeip
namespace: kube-system
rules:
- apiGroups: [""]
resources: ["nodes"]
Expand Down

0 comments on commit b4a01fd

Please sign in to comment.