Update French & Turkish translations #956
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mainly for the Sidekick part, also added a few missing strings to the French translation and reverted to use the original "Ledger" word in the Turkish one.
Hopefully this will silence the error.
and fix a few typos in the process.
Hopefully there aren't many left.
Crossing fingers, click & pray.
|
Wouldn't it be preferable to have separate PRs for the Turkish and French updates? Easier to review. (I think the French update looks legit, though. Just did a quick review) |
|
On 20.10.2024 11:59, Ordtrogen wrote:
Wouldn't it be preferable to have separate PRs for the Turkish and
French updates? Easier to review.
Should I close this PR and open two new ones, one for French and another
one for Turkish?
|
|
Would you like me to import this into Weblate? #966 |
|
On 6.11.2024 02:03, Lucas wrote:
Would you like me to import this into Weblate? #966 <https://github.com/
m2049r/xmrwallet#966>
Of course. Thanks for your work on this.
|
|
OK, you can leave this open until (if) that gets merged |
|
please check & resolve the conflicts |
Let's see if this resolves the conflicts.
Forgot to remove the translatable="false" strings without which my diff tool freaked out, and fixed a few typos. Let's hope this will resolve the conflicts.
|
@cardpuncher I can do this for you if you'd like |
Forgot to save the file... :/
Remove duplicate string.
|
On 7.12.2024 17:44, Lucas wrote:
@cardpuncher <https://github.com/cardpuncher> I can do this for you if
you'd like
Hey, yeah that would be great. If my latest change doesn't fix the
issues, I'm letting you finish the job. Thanks!
|
|
@lucasmz-dev has a new PR #984 including these translations, so I think closing this one makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly for the Sidekick part, also added a few missing strings to the French translation and reverted to use the original "Ledger" word in the Turkish one.