Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try and improve the translation situation #960

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

lucasmz-dev
Copy link

There a few issues with Monerujo maintenance issues.

  • A handful of strings are outdated; the source string was modified but the translation was never removed; this is where we get inconsistent strings that can only be corrected if the translators goes through every string, which is even harder since monerujo is not on something like Weblate as a translation platform #958 !

  • Newly added strings are added into the translation files because monerujo does not ignore the linter flag "MissingTranslation", because monerujo does crowd-sourced translation, this flag doesn't make sense to keep enabled! These english strings also mean can also affect how Android deals with fallbacks, e.g. when there are strings for PT available that could be used but the user is using PT-BR

This PR should help with integrating with #958 as a possibility in the future and it is its main focus

It is important to note, ideally when source strings are changed or removed, they are also altered in translations, so they don't take effect in the app anymore. This makes translators' jobs easier.

@lucasmz-dev lucasmz-dev marked this pull request as ready for review September 26, 2024 02:13
@lucasmz-dev
Copy link
Author

The english duplicate strings COULD be kept, but ideally inside a comment.

Removes strings from translations, where the string was translated and the source string was later changed, but the translation never invalidated

May potentially not include all strings, the process to find them was to look into Git Blame and see weird dates and what was changed.
We don't need this, we ignore the MissingTranslation flag.
It also means it fallbacks to another variant if available, instead of always being english.
Quick find and replace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant