Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Swedish translation from ordtrogen #985

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lucasmz-dev
Copy link
Contributor

Plays it safe, some strings are removed

@lucasmz-dev
Copy link
Contributor Author

@ordtrogen Can you quickly check this to check if the translations don't seem weird?

@lucasmz-dev lucasmz-dev marked this pull request as ready for review December 13, 2024 04:25
@ordtrogen
Copy link
Contributor

Having checked it, nothing seems weird. There are indeed some source strings that have changed since I made the translation but I consider these a minor issue and that it's worth getting this larger update merged.

When that's done, I'll happily go through it once more and make the last few edits required.

Maybe it can even be done in Weblate, depending on how far that has come.

@lucasmz-dev lucasmz-dev marked this pull request as draft December 18, 2024 00:41
@lucasmz-dev lucasmz-dev marked this pull request as ready for review December 18, 2024 00:45
@ordtrogen
Copy link
Contributor

Is there anything I can do?

@lucasmz-dev
Copy link
Contributor Author

@ordtrogen thanks but not for now, my plan is to get these things merged, then try to deal with fuzzy translations globally with #986 and then open up weblate
if you want you can Watch the weblate project and you'll be notified of when things happen and you can translate more if you'd like

as long as the translations don't look just wrong here, everything's ok, if they do, add a comment on them (+ icon next to a string when you check edited files)

when weblate does get unlocked, if you somewhat plan to look through everything (i hope to make this mostly unnecessary for everyone, but I need to figure things out to be able to do that) you could add comments to any fuzzy translations (translations that are out of date but not marked as so, you'll notice because they might say a completely different thing) and that'd help a lot, actually! but i see you kind of already did this with the swedish translation so not needed

(last force-pushes were because i figured out I could set you as the author of the commit without using Co-authored-by:)

@ordtrogen
Copy link
Contributor

Im looking at https://hosted.weblate.org/projects/monerujo/ and it says "We are currently in maintenance. We hope to make your translation experience better soon."

And I don't see a "Watch" feature on Weblate proper. Is there a "monerujo weblate" project on GitHub I should watch?

@lucasmz-dev
Copy link
Contributor Author

its this thing
image

and yes it's locked for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants