Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add low_memory option #40

Merged
merged 11 commits into from
Jun 26, 2024
Merged

add low_memory option #40

merged 11 commits into from
Jun 26, 2024

Conversation

lmiq
Copy link
Member

@lmiq lmiq commented Jun 26, 2024

This PR adds the low_memory option to the mddf function which, set to true:

  • Defines the number of chunks to use at most 20% of the total memory of the system,
    considering the size of the results data structure.
  • Parallelizes the execution of CellListMap to use nthreads/nchunks number of threads.

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 94.79769% with 9 lines in your changes missing coverage. Please review.

Project coverage is 86.68%. Comparing base (31f7406) to head (4bc63c6).

Files Patch % Lines
src/mddf.jl 94.11% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
+ Coverage   85.01%   86.68%   +1.67%     
==========================================
  Files          23       24       +1     
  Lines        1248     1367     +119     
==========================================
+ Hits         1061     1185     +124     
+ Misses        187      182       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lmiq lmiq merged commit 1d6c70b into main Jun 26, 2024
17 checks passed
@lmiq lmiq deleted the low_memory branch June 26, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant