-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added lock to move the card on an axis #65
base: master
Are you sure you want to change the base?
Conversation
@mac-gallagher I added an enum to drag card from a unique axis. |
Hey @andre991 thanks for opening this pull request. I tried the same thing after you opened #64, but the cards behave unexpectedly in the example project. If you drag horizontally, the card slides downwards because there is a rotation angle on the card animation options. It may require some changes to |
Hi @mac-gallagher I will test this in example project, but in my project the animation looks normal. The rotation is work perfectly for me. You have an gif to share? |
Hi @mac-gallagher, sorry for the delay. The axis is to block card movement for other Axis. Look at the mouse movement. |
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
========================================
- Coverage 82.3% 81.2% -1.1%
========================================
Files 13 14 +1
Lines 656 672 +16
========================================
+ Hits 540 546 +6
- Misses 116 126 +10
|
Hey @andre991 yes I understand - your change blocks the card movements in the specified directions just fine. However, I would expect everything else to remain the same. The card follows different trajectories for a horizontal drag with |
Added the Axis enum to allow card to move from a unique axis or both.
Issue #64