Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Result processor implementation in go #88

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Result processor implementation in go #88

merged 3 commits into from
Oct 25, 2024

Conversation

samparent97
Copy link
Contributor

No description provided.

@samparent97 samparent97 force-pushed the user/sparent/go-result-processor branch from 916a973 to 46ca7da Compare October 4, 2024 21:58
@samparent97 samparent97 changed the title Make new result processor implementation in go Result processor implementation in go Oct 4, 2024
@BlakeFreer
Copy link

Merging this branch will include the code from #89 since it points to a commit in history of this branch.

@samparent97
Copy link
Contributor Author

samparent97 commented Oct 6, 2024 •
edited
Loading

Merging this branch will include the code from #89 since it points to a commit in history of this branch.

Yep, I rebased it on top of that PR. Those changes are needed, so we will need to get that one in first.

@samparent97 samparent97 mentioned this pull request Oct 10, 2024
Closed
@samparent97 samparent97 force-pushed the user/sparent/go-result-processor branch from 417f9ed to 19f2f1a Compare October 10, 2024 14:45
@samparent97 samparent97 linked an issue Oct 10, 2024 that may be closed by this pull request
Go Results Processor #86
Closed
TylerStAmour
TylerStAmour previously approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@TylerStAmour TylerStAmour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, no major comments

results/htmlreportgenerator.go Show resolved Hide resolved
results/resultaccumulator.go Show resolved Hide resolved
@BlakeFreer BlakeFreer mentioned this pull request Oct 24, 2024
Open
@samparent97 samparent97 force-pushed the user/sparent/go-result-processor branch from f95693f to 333627b Compare October 25, 2024 14:20
@samparent97 samparent97 force-pushed the user/sparent/go-result-processor branch from 333627b to d35bd7b Compare October 25, 2024 14:22
@samparent97 samparent97 merged commit dc782f4 into main Oct 25, 2024
1 check passed
@samparent97 samparent97 deleted the user/sparent/go-result-processor branch October 25, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlakeFreer BlakeFreer BlakeFreer left review comments

@TylerStAmour TylerStAmour TylerStAmour approved these changes

@langei langei Awaiting requested review from langei

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Go Results Processor
3 participants
@samparent97 @BlakeFreer @TylerStAmour