Changing PosixPath to WindowsPath when on Windows
#96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanv
reviewed
Feb 2, 2022
| @@ -87,7 +88,12 @@ def initialize_csv_file(csv_fname): | |||
| ------- | |||
| None | |||
| """ | |||
| if platform.startswith('win'): | |||
| temp = PosixPath | |||
| PosixPath = WindowsPath | |||
There was a problem hiding this comment.
This only patches in the local namespace, so will it be enough?
There was a problem hiding this comment.
That solution was proposed by @bwprice; I don't have a Windows machine around to test it, though. Could you confirm if the pipeline works properly when you use this, Ben?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows doesn't have
PosixPathavailable. This patch suggested by @bwprice makes the pipeline work properly on Windows machines.Solves #86.