-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
krunkit libkrun virglrenderer: new ports #27208
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the submissions @tsujp. I've left a few comments, they apply to all ports.
Also, each ports should be in a different commit please.
d983377
to
d7509e7
Compare
Changes made; requested re-review. |
I note that It fails around extracting virglrenderer (as of course it prompts to install dependencies). I'm very tired right now so I'm not sure why or if it's actually important?
|
Small bump @reneeotten are you able to re-review? |
That's expected, trace mode is broken on arm64. See https://trac.macports.org/ticket/66358. In general this looks good. Let me know what whether you want to change something in response to my comments. Meanwhile, I'll give this a test with trace mode on my machine (where I have a working setup with some magic that's not quite production-ready). |
graphics/virglrenderer/Portfile
Outdated
depends_run port:libepoxy \ | ||
port:moltenvk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both of these are required at build time and runtime, so they should be depends_lib
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
depends_run
changed to depends_lib
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
virglrenderer
still fails to find moltenvk if the rpath
patch from krunkit
is removed.
With my suggested changes applied, I can report that this works as expected:
|
Since I added c0defa8 it appeared to build correctly in MacPorts CI so it's curious something was missing (or it still built but with a warning and I missed it). In any case thanks for the review and additional confirmation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also please check these are the latest upstream versions - the PR is quite old and perhaps upstream has released again?
Also, please make the changes @neverpanic requested.
On it now.
|
6c2f407
to
7c7f336
Compare
* Specifically this is slp's fork for use in libkrun.
* Specifically this is the EFI flavour for use in krunkit.
7c7f336
to
8d55272
Compare
@neverpanic @reneeotten changed made, please re-review. |
Even with
krunkit still functions correctly (output has always been 0.0.0, I've never seen it have libkrun-efi's actual version number there). |
Description
Three (3) new ports:
krunkit allows running VMs on macOS using Hypervisor.framework with hardware accelerated graphics using Venus.
Podman can also use krunkit as a driver instead of the default applehv (Virtualization.framework). If you configure Podman to use krunkit you can run hardware accelerated graphics workloads within the VM (and thus containers) Podman manages on your macOS hosts.
libkrun allows use of more modern versions of virtio and has some advanced networking features (although the latter is not enabled by default nor available at all as I cannot be bothered).
There are a few questions I have regarding this:
libkrun
variant to the Podman port, this would simply addkrunkit
as a runtime dependency. Strictly speaking uninstallingkrunkit
would not break Podman as Podman executes the binarykrunkit
when configured to use it. It does feel nicer to be able to install Podman withkrunkit
in one go though. Shall I add said variant?virglrenderer
here is slp's fork as already mentioned. Would you prefer I change the Portfile to use upstreamvirglrenderer
and add alibkrun
variant tovirglrenderer
which uses slp's or shall we leave the Portfile as-is only use slp's for now? In the former case how does one specify a variant inbuild_run
?Once those questions have answers I can do some final cleanup on the Portfiles (as I've left the TODOs in so I do not forget).
Type(s)
Tested on
macOS 14.5 23F79 arm64
Xcode 16.0 16A242d
Verification
Have you
port lint
?sudo port -vst install
?