-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Volk: Update to 3.1.2 and add Python 3.11 and 3.12 variants #27425
Conversation
Notifying maintainers: |
science/volk/Portfile
Outdated
@@ -126,7 +122,7 @@ configure.cppflags-delete -I${prefix}/include | |||
# specify the Python dependencies; these are checked for at configure, | |||
# then used for building, but not at runtime. | |||
|
|||
set pythons_suffixes {35 36 37 38 39 310} | |||
set pythons_suffixes {35 36 37 38 39 310 311 312} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we remove all the EOL Python versions? You'd need to double check that there are no dependents, of course.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea which ones are EOL, however it also seems a bit pointless to not add them when the Python versions are in Macports.
ie that seems like a policy decision outside the scope of a single port.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, you can easily find that right... Everything below 3.9 is EOL and it's a MacPort policy - that's why I am asking. From the variant description it appears Python is only a build dependency and thus it should be safe to do so. But please verify that it doesn't install Python bindings or something like that, and see if other ports depend on a specific variant (unlikely).
Also, your commit message doesn't follow our guidelines. It should be "portname: short description".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK I've removed the EOLd versions - with respect to it being policy that is fine but it seems difficult to find such information in the "how to make a port" docs.
I have also fixed up the commit log.
It does install a Python library as part of volk_modtool, not sure if that applies to what you have said.
I do not know how to check what other ports use it.. I tried 'port dependentof volk' but it only returned volk which was less than helpful.
cf9ae57
to
985e3c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one more thing to change, the comment was there for a reason 😉. I'll check whether another port relies on certain Python variants when I have the chance.
Description
Update volk to 3.1.2 and add Python 3.11 and 3.12 variants
Fixes https://trac.macports.org/ticket/71416
Tested by running GRC.
I have not tested it on ARM64 as I don't have suitable hardware so I am not sure about the deleted patch - it does not apply but I am not sure if the problem was fixed upstream.
Type(s)
Tested on
macOS 15.2 24C101 x86_64
Xcode 16.2 16C5032a
Verification
Have you
port lint
?sudo port test
?sudo port -vst install
?