Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlite3: Avoid rpath; tweak install name #27603

Merged
merged 1 commit into from
Feb 9, 2025

Conversation

ryandesign
Copy link
Contributor

Description

Don't use -rpath since it's never needed and causes an error with older compilers.

Closes: https://trac.macports.org/ticket/72018

Change the install name from /opt/local/lib/libsqlite3.dylib back to /opt/local/lib/libsqlite3.0.dylib as it was in 3.48.0 and earlier.

Change the install name in post-build not post-destroot and use shellescape when doing so.

See: https://trac.macports.org/ticket/72021

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 12.7.5 21H1222 x86_64
Xcode 14.2 14C18

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@Schamschula for port sqlite3.

@macportsbot macportsbot added maintainer: open Affects an openmaintainer port by: member Created by a member with commit rights labels Feb 9, 2025
@Schamschula
Copy link
Contributor

Ryan,

First of all, many thanks for helping to get this critical package back!

I hadn't seen this PR when I went in to deal with shellescape and to add the note.

@Schamschula
Copy link
Contributor

I'm good with this!

Don't use -rpath since it's never needed and causes an error with older
compilers.

Closes: https://trac.macports.org/ticket/72018

Change the install name from /opt/local/lib/libsqlite3.dylib back to
/opt/local/lib/libsqlite3.0.dylib as it was in 3.48.0 and earlier.

Simplify how the install name is fixed and do so in post-build not
post-destroot.

See: https://trac.macports.org/ticket/72021
@ryandesign
Copy link
Contributor Author

ryandesign commented Feb 9, 2025

Sorry about the duplicated work! I thought I could get mine done before you had started on anything.

@ryandesign ryandesign merged commit 8707fad into macports:master Feb 9, 2025
3 checks passed
@ryandesign ryandesign deleted the sqlite3 branch February 9, 2025 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port
Development

Successfully merging this pull request may close these issues.

3 participants