Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py-awscli2: add python 3.13 #27604

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

bcully
Copy link
Contributor

@bcully bcully commented Feb 9, 2025

Description

Add python 3.13 support to py-awscli2

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 15.3 24D60 x86_64
Command Line Tools 16.2.0.0.1.1733547573

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

port lint does complain that this conflicts with nonexistent port py313-awscli. I didn't think it made sense to add that version in this PR or to try to avoid the conflict now (which would become necessary if the py313-awscli version were added. It also looks like py312-awscli was added long before py313-awscli2 so I think this is "tradition".

@macportsbot
Copy link

Notifying maintainers:
@dgilman for port py-awscli2.

@macportsbot macportsbot added type: enhancement maintainer: open Affects an openmaintainer port labels Feb 9, 2025
@dgilman
Copy link
Contributor

dgilman commented Feb 9, 2025

Upstream does’t (officially) support 3.13 yet which is why I haven’t added it to this package. Did you run the pytest suite?

@bcully
Copy link
Contributor Author

bcully commented Feb 9, 2025

I did run port test which I had assumed ran the test suite. I also used aws s3 ls on a bucket of mine to spot check it. That was about the extent of my testing though.

Copy link
Contributor

@dgilman dgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The Portfile used to have the unit tests set up but doesn't anymore so the port test was a no-op. I ran the test locally and got what I would consider expected failures.

There is a MacPorts policy around the "official" version of Python for the distribution and I don't know if 3.13 has been promoted to that yet. They may delay the merging of this PR until that's happened but I am not positive if this package needs to follow that default.

@bcully
Copy link
Contributor Author

bcully commented Feb 9, 2025

Ok. There do seem to be a number of packages already on 3.13 - that's actually why I bothered to upgrade this one, so I could uninstall 3.12. But I'm not super bothered either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port type: enhancement
Development

Successfully merging this pull request may close these issues.

3 participants