Use the correct format specifiers #810
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opt_len, static_len, bits_sent, etc. are all unsigned longs, not signed longs.
AreaZR
changed the title
| @@ -109,7 +109,7 @@ static char *strwinerror (error) | |||
| LocalFree(msgbuf); | |||
| } | |||
| else { | |||
| sprintf(buf, "unknown win32 error (%ld)", error); | |||
| sprintf(buf, "unknown win32 error (%u)", error); | |||
There was a problem hiding this comment.
DWORD is unsigned int (yeah I know) on windows
There was a problem hiding this comment.
DWORD is unsigned int
DWORD is unsigned long
There was a problem hiding this comment.
typedef unsigned long DWORD, *PDWORD, *LPDWORD;
|
@madler: Can you look this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opt_len, static_len, bits_sent, etc. are all unsigned longs, not signed longs.
For this reason, the Trace_ev strings should be changed to reflect that.