Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: Directory pathnames may now contain the equals sign. #854

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

DoctorNoobingstoneIPresume

The user is allowed to specify directory pathnames using --prefix=PATHNAME etc., but the extraction of the PATHNAME used to use a regex which eliminated everything until the last equals sign.

We have switched to eliminating everything until the first equals sign.

The user is allowed to specify directory pathnames using --prefix=PATHNAME etc.,
but the extraction of the PATHNAME used to use a regex which eliminated
everything until the last equals sign.

We have switched to eliminating everything until the first equals sign.
@DoctorNoobingstoneIPresume
Copy link
Author

I have tried "non-greedy repetition" by changing .*= to .*?=:

echo "--prefix=xxx=yyy" | sed s'/.*?=//'

but it does not seem to work for me.

@DoctorNoobingstoneIPresume
Copy link
Author

I wish we could create a function which executes echo $1 | sed 's/[^=]*=// and call it instead of repeating the code in the processing of --prefix=, --eprefix=, --libdir=, --sharedlibdir=, --includedir=, --uname=, --archs= etc.

@Neustradamus
Copy link

@madler: Can you look this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants