Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create msbuild.yml This appears to be an in-progress workflow that will allow building of zlib using the commandline version of Microsoft Visual Studio. That would be good thing to have for automated testing. #953

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

MC-MAGA
Copy link

@MC-MAGA MC-MAGA commented Mar 17, 2024

No description provided.

@madler
Copy link
Owner

madler commented Mar 17, 2024

Please provide a description and rationale for the pull request.

@pmqs
Copy link
Contributor

pmqs commented Mar 19, 2024

This appears to be an in-progress workflow that will allow building of zlib using the commandline version of Microsoft Visual Studio. That would be good thing to have for automated testing.

Problem is, it doesn't work in its current form.

@MC-MAGA your own test run with this workflow failed (https://github.com/MC-MAGA/zlib/actions/runs/8314919535) in the nuget step. I don't know nuget, so no idea what it is supposed to do in this context.

@MC-MAGA MC-MAGA changed the title Create msbuild.yml Create msbuild.yml This appears to be an in-progress workflow that will allow building of zlib using the commandline version of Microsoft Visual Studio. That would be good thing to have for automated testing. Mar 30, 2024
Copy link
Author

@MC-MAGA MC-MAGA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In-progress workflow that will allow building of zlib using the commandline version of Microsoft Visual Studio. That would be good thing to have for automated testing.

@pmqs
Copy link
Contributor

pmqs commented Mar 30, 2024

@MC-MAGA can you get the workflow operating properly?

@Neustradamus
Copy link

@MC-MAGA: Have you progressed on your PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants