Merge pull request #41 from mageplaza/2.4-develop

2.4 develop
mageplaza · Sep 12, 2022 · c82a228 · c82a228
2 parents 225aff1 + fc3ecbd
commit c82a228
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/Plugin/AbstractFormat.php b/Plugin/AbstractFormat.php
@@ -236,7 +236,7 @@ public function getSubjectRate($subject, $row)
         if ($rate = $subject->getColumn()->getRate()) {
             return (float) $rate;
         }
-        if ($rate = $row->getData($subject->getColumn()->getRateField())) {
+        if ($subject->getColumn()->getRateField() && $rate = $row->getData($subject->getColumn()->getRateField())) {
             return (float) $rate;
         }
 

diff --git a/Plugin/Directory/PriceCurrency.php b/Plugin/Directory/PriceCurrency.php
@@ -64,7 +64,7 @@ public function aroundRound(DirectoryPriceCurrency $subject, callable $proceed,
             return $proceed($price);
         }
 
-        return round($price, $this->getPrecision());
+        return round((float)$price, $this->getPrecision());
     }
 
     /**

diff --git a/composer.json b/composer.json
@@ -2,10 +2,10 @@
   "name": "mageplaza/module-currency-formatter",
   "description": "Magento 2 Currency Formatter Extension",
   "require": {
-    "mageplaza/module-core": "^1.4.5"
+    "mageplaza/module-core": "^1.4.12"
   },
   "type": "magento2-module",
-  "version": "4.0.6",
+  "version": "4.0.7",
   "license": "proprietary",
   "authors": [
     {
-Original file line number
+Diff line change
@@ Expand Up @@
                 return $proceed($price);
             }
-            return round($price, $this->getPrecision());
+            return round((float)$price, $this->getPrecision());
         }
         /**
@@ Expand Down @@