Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update configuration for PHPUnit 10.x compatibility #413

Closed
wants to merge 2 commits into from
Closed

Update configuration for PHPUnit 10.x compatibility #413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b674aa9
Update configuration for PHPUnit version 10
fredden Sep 18, 2023
faf33b7
Mark test providers as static
fredden Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,20 +5,17 @@
bootstrap="./vendor/autoload.php"
cacheResultFile="build/.phpunit.result.cache"
colors="true"
convertErrorsToExceptions="true"
convertNoticesToExceptions="true"
convertWarningsToExceptions="true"
verbose="true"
stopOnFailure="false"
processIsolation="false"
backupGlobals="false"
>
<testsuite name="ComposerRequireChecker tests">
<directory>./test/ComposerRequireCheckerTest</directory>
</testsuite>
<coverage includeUncoveredFiles="true">
<coverage includeUncoveredFiles="true" />
<source>
<include>
<directory suffix=".php">./src</directory>
</include>
</coverage>
</source>
</phpunit>
4 changes: 2 additions & 2 deletions ...quireCheckerTest/DefinedSymbolsLocator/LocateDefinedSymbolsFromComposerRuntimeApiTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,15 @@ public function testInstalledVersionsSymbol(string $composerJson): void
self::assertContains('Composer\InstalledVersions', $symbols);
}

public function provideComposerJsonWithUnsuitableComposerRuntimeApi(): Generator
public static function provideComposerJsonWithUnsuitableComposerRuntimeApi(): Generator
{
yield ['{ "require": { "composer-runtime-api": "^1.0" } }'];
yield ['{ "require": { "composer-runtime-api": "^1" } }'];
yield ['{ "require": { "composer-runtime-api": "~1" } }'];
yield ['{ "require": { "composer-runtime-api": "=1" } }'];
}

public function provideComposerJsonWithSuitableComposerRuntimeApi(): Generator
public static function provideComposerJsonWithSuitableComposerRuntimeApi(): Generator
{
yield ['{ "require": { "composer-runtime-api": "^2.0" } }'];
yield ['{ "require": { "composer-runtime-api": "^2" } }'];
Expand Down
2 changes: 1 addition & 1 deletion test/ComposerRequireCheckerTest/FileLocator/LocateAllFilesByExtensionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ public function testLocateWithBlackList(array $blacklist, array $expectedFiles):
}

/** @return array<string, array<array<string>>> */
public function provideBlacklists(): array
public static function provideBlacklists(): array
{
return [
'No blacklist' => [
Expand Down
2 changes: 1 addition & 1 deletion test/ComposerRequireCheckerTest/FileLocator/LocateComposerPackageSourceFilesTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ public function testFromPsr4WithExcludeFromClassmap(array $excludedPattern, arra
}

/** @return array<string, array<array<string>>> */
public function provideExcludePattern(): array
public static function provideExcludePattern(): array
{
return [
'No exclude pattern' => [
Expand Down
Loading