Elastic Food Demand and Tax recycling

[bodirsky]

🐦 Description of this PR 🐦

• Bugfix of the price iteration between magpie and demand module

• Introduced Tax recycling. Revenue from greenhouse gas taxation is recycled to consumers as per-capita premium to income.

🔧 Checklist for PR creator 🔧

• Label pull request from the label list.

  • Low risk: Simple bugfixes (missing files, updated documentation, typos) or changes in start or output scripts
  • Medium risk: Uncritical changes in the model core (e.g. moderate modifications in non-default realizations)
  • High risk: Critical changes in model core or default settings (e.g. changing a model default or adjusting a core mechanic in the model)

• Self-review own code

  • No hard coded numbers and cluster/country/region names.
  • The new code doesn't contain declared but unused parameters or variables.
  • magpie4 R library has been updated accordingly and backwards compatible where necessary.
  • scenario_config.csv has been updated accordingly (important if default.cfg has been updated)

• Document changes

  • Add changes to CHANGELOG.md
  • Where relevant, put In-code documentation comments
  • Properly address updates in interfaces in the module documentations
  • run goxygen::goxygen() and verify the modified code is properly documented

• Perform test runs

  • Low risk:

    • Run a compilation check via Rscript start.R --> "compilation check"

  • Medium risk:

    • Run test runs via Rscript start.R --> "test runs"
    • Check logs for errors/warnings

  • High risk:

    • Run test runs via Rscript start.R --> "test runs"
    • Check logs for errors/warnings
    • Default run from the PR target branch for comparison
    • Provide relevant comparison plots (land-use, emissions, food prices, land-use intensity,...)

    test run scenario setup:
    3 taxation scenarios with full tax recycling (1), medium (0.5) and none (0)
    A scenario without taxation (Ref-1)
    A scenario without taxation and without elastic demand (Ref-inelastic)

total calories: no major changes


some changes in ruminant meat consumption in SSA
Taxation with tax recycling has almost no effect, only if taxes are not recycled consumption declines

food expenditure rises in taxation scenarios.
Price drop in 2025, as the model switches from exogenous prices to endogenous prices in the elastic version of the model. Drop would be lower if our prices would be more realistic.

📉 Performance changes 📈

• Current develop branch default : ** mins
• This PR's default : ** mins

🚨 Checklist for reviewer 🚨

• PR is labeled correctly
• Code changes look reasonable
  • No hard coded numbers and cluster/country/region names.
  • No unnecessary increase in module interfaces
  • model behavior/performance is satisfactory.
• Changes are properly documented
  • CHANGELOG is updated correctly
  • Updates in interfaces have been properly addressed in the module documentations
  • In-code documentation looks appropriate
• content review done (at least 1)
• RSE review done (at least 1)

[xwangatpik]

The bugfixing for elastic demand looks good to me and Jiaqi.

[flohump]

The bugfixing for elastic demand looks good to me and Jiaqi.

Thanks for looking into it!
Can you add a review and approve (or request changes)?

[flohump]

Thanks for these improvement.
Looks fine overall.
Please mention in the CHANGELOG that you removed modules/15_food/anthropometrics_jan18
You changed 3 renv files. Please double check

[flohump]

Thanks for clarifying.
Before you proceed you need to sort out merging conflicts.

[deleip]

Looks good to me, just two small questions

[weindl]

Looks good, thank you.

[weindl]

The name of the switch 's15_tax_recycling' that determines how GHG tax revenues are recycled is very similar to the name of the parameter 'p15_tax_recycling(t,iso)'.
Would it be an idea to rename one of them to make the code easier to read?

all requested changes done. now want to merge