Skip to content

Commit

Permalink
web: fix mobile scrolling bug (goauthentik#12601)
Browse files Browse the repository at this point in the history
* web: Add InvalidationFlow to Radius Provider dialogues

## What

- Bugfix: adds the InvalidationFlow to the Radius Provider dialogues
  - Repairs: `{"invalidation_flow":["This field is required."]}` message, which was *not* propagated
    to the Notification.
- Nitpick: Pretties `?foo=${true}` expressions: `s/\?([^=]+)=\$\{true\}/\1/`

## Note

Yes, I know I'm going to have to do more magic when we harmonize the forms, and no, I didn't add the
Property Mappings to the wizard, and yes, I know I'm going to have pain with the *new* version of
the wizard. But this is a serious bug; you can't make Radius servers with *either* of the current
dialogues at the moment.

* This (temporary) change is needed to prevent the unit tests from failing.

\# What

\# Why

\# How

\# Designs

\# Test Steps

\# Other Notes

* Revert "This (temporary) change is needed to prevent the unit tests from failing."

This reverts commit dddde09.

* web: adjust spacing issue for the login container

# What

Replaces the `space-evenly` flexbox instruction with `space-between`. `space-evenly` introduced
whitespace in column mode that pushed visible content off the page by introducing new margins inside
the flex container, which made content pushed around by those margins inaccessable via scrolling.
`space-between` creates the same desired effect, but with the margins top and bottom of the flexbox
column controlled by the parent container, which gives both more control and more suitable layout
handling.

# Links:

- Zendesk Ticket: [Tall Prompts/Flows cut off on
  Safari](https://authentiksecurityinc.zendesk.com/agent/tickets/186). (This link is only visible to
  Authentik employees. Sorry.)
  • Loading branch information
kensternberg-authentik authored and mahmoudajawad committed Jan 15, 2025
1 parent 9a6be33 commit 7c65cd3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion web/src/common/styles/authentik.css
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ html > form > input {
width: 35rem;
display: flex;
flex-direction: column;
justify-content: space-evenly;
justify-content: space-between;
}
.pf-c-login__header {
flex-grow: 1;
Expand Down

0 comments on commit 7c65cd3

Please sign in to comment.