Add a TODO

mahozad · Mar 20, 2024 · ce02e1c · ce02e1c
1 parent 0c9d8a3
commit ce02e1c
Showing 1 changed file with 15 additions and 0 deletions.
diff --git a/library/src/commonMain/kotlin/ir/mahozad/multiplatform/wavyslider/material3/WavySlider.kt b/library/src/commonMain/kotlin/ir/mahozad/multiplatform/wavyslider/material3/WavySlider.kt
@@ -412,6 +412,21 @@ fun WavySlider(
     val state = remember(valueRange, onValueChangeFinished) {
         SliderState(value, 0, onValueChangeFinished, valueRange)
     }
+    /*
+     TODO: Replace above with the below Compose Multiplatform 1.6.1 implementation
+      The @Suppress("INVISIBLE_SETTER") below does not work on Android because
+      the fix in https://github.com/JetBrains/compose-multiplatform/issues/4366
+      has not yet been upstreamed to Compose in AOSP.
+      ```
+      val onValueChangeFinishedState = rememberUpdatedState(onValueChangeFinished)
+      val state = remember(valueRange) {
+          SliderState(value, 0, { onValueChangeFinishedState.value?.invoke() }, valueRange)
+      }
+      @Suppress("INVISIBLE_SETTER")
+      state.onValueChangeFinished = onValueChangeFinished
+      ```
+     */
+
     @Suppress("INVISIBLE_MEMBER")
     state.onValueChange = onValueChange
     state.value = value