Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.x] Live preview #30

Merged
merged 25 commits into from
Apr 15, 2024
Merged

[2.x] Live preview #30

merged 25 commits into from
Apr 15, 2024

Conversation

danilopolani
Copy link
Contributor

@danilopolani danilopolani commented Mar 23, 2024 •
edited
Loading

  • Make it work with Monaco editor
  • Find a better solution to refresh iframe? Both to remove the $this->js() call, both to render a new iFrame in front of it and then remove the old one to avoid the "scatter" effect
  • Ignore variables when rendering preview
  • Add and extract variables from template into editor
  • Generate QRCode for live mobile preview
  • Remove buttons at top to manually refresh the preview etc.
  • Understand why HTML/Twig is not highlighted in CodeMirror
  • Lazy load JS for CodeMirror
  • CodeMirror dark/light theme
  • Automatically add new variables from template into variables // ABORTED: Not so easy, since it would add even unincomplete variables names as the user types

@danilopolani danilopolani added the enhancement New feature or request label Mar 23, 2024
@danilopolani danilopolani self-assigned this Mar 23, 2024
@danilopolani
make template preview route without auth
cc484a4
@danilopolani
set preview for correct field
0847dfe
@danilopolani
remove monaco and reimplement codemirror
2198324
@danilopolani
add template variables to preview
e485c95
@danilopolani
prefill correctly preview variables
f44aa80
@danilopolani
fix codemirror live edits
4f836b4
@danilopolani
align with master
57ec4f3
@danilopolani
do not render preview if has rendering errors
24b1c0d
@danilopolani
override builder editor view
8b80405
@danilopolani
first draft of livewire to render real-time preview
73464bb
@danilopolani
use livewire full-page component also in the iframe
cd611d0
@danilopolani
show notification when accepting live preview edits
9e4c7c0
@danilopolani
fix style
8f059dd
@danilopolani
start working on mobile qrcode
0c04b1f
@danilopolani
add warning if device preview running on localhost
32138bc
@danilopolani
add close button to live preview modal
45f8553
@danilopolani
fix style
66e19a5
@danilopolani
customize qrcode colors
0f5108a
@danilopolani
add logo to qrcode
7afbd15
@danilopolani
fix code editor highlight
b0c1979
@danilopolani
adapt code editor theme to system preferences
399732c
@danilopolani
move close button to the right
14d5270
@danilopolani
fix covariant type
28d567c
@danilopolani danilopolani merged commit 7312ae5 into master Apr 15, 2024
11 checks passed
@danilopolani danilopolani deleted the feat/live-preview branch April 15, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@danilopolani danilopolani

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@danilopolani