Bug/required field does not display as required in the WP Mailchimp settings page

[MaxwellGarceau]

Description of the Change

In order to avoid duplicating information, please see #102 for a description of the original bug.

merge-field-required-label-does-not-appear-in-wp-admin.mov

Solution

Update strict equality comparison check to force the required field to have the same type. This fixes the bug and will cause merge fields to correctly display if they are required in the Mailchimp WP admin page.

Closes #102

How to test the Change

This video in the "Description of the Change" demonstrating the original bug can be used as a walkthrough. However, instead of the bug you should see the fix.

1. Log into the test user Mailchimp account and set a sampling of the merge fields to required.
2. Log into the WordPress site -> navigate to the Mailchimp settings page -> Click "Update List" to refresh the Mailchimp data.
3. Navigate down to the merge field tags section. The required labels should reflect whether the field is or is not required in the Mailchimp account.

Changelog Entry

Fixed - Bug causing merge fields on the Mailchimp WP admin page to incorrectly display as not required when they were, in fact, required.

Credits

Props @MaxwellGarceau

Checklist:

• I agree to follow this project's Code of Conduct.
• I have updated the documentation accordingly. Small change, no documentation to update
• I have added tests to cover my change. Small change, not worth the test
• All new and existing tests pass.

[github-actions]

@MaxwellGarceau thanks for the PR! Could you please fill out the PR template with description, changelog, and credits information so that we can properly review and merge this?

[MaxwellGarceau]

@MaxwellGarceau thanks for the PR! Could you please fill out the PR template with description, changelog, and credits information so that we can properly review and merge this?

Done

[MaxwellGarceau]

Removing request for a review from @qasumitbagthariya so that @dkotter can be the person to advance tickets to the next stage (read your note on #97 (comment) just a little too late haha).

[qasumitbagthariya]

Regression / Smoke Test Report ✅

Tested with the smoke-testing branch, it works as expected, similar to the fix-specific branch.

Screen.Recording.2025-01-28.at.5.31.33.PM.1.mov

Testing Environment

• WordPress: 6.7.1
• Theme: Twenty Twenty-Four 1.3
• WooCommerce - 9.5.1
• PHP: 8.0.30
• Web Server: Nginx 1.20.2
• Browser: Chrome
• OS: macOS 15.2
• Branch: smoke-testing