Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix builds for PRs originating from forks #172

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

marcoow
Copy link
Member

@marcoow marcoow commented Oct 14, 2024

Those action runs don't have access to our private font repo so we're using a fallback font instead.

Copy link

netlify bot commented Oct 14, 2024

Deploy Preview for taupe-lily-3539f6 ready!

Name Link
🔨 Latest commit 4ca49fa
🔍 Latest deploy log https://app.netlify.com/sites/taupe-lily-3539f6/deploys/670cf8d9df38de0008d967ed
😎 Deploy Preview https://deploy-preview-172--taupe-lily-3539f6.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@marcoow marcoow force-pushed the fix-fork-build branch 9 times, most recently from 50f6a0e to c35ee5a Compare October 14, 2024 10:23
@marcoow marcoow changed the title tmp Fix builds for PRs originating from forks Oct 14, 2024
Comment on lines +35 to +38
sed -i 's/"BoldFont=CoreSansA65.ttf",//g' book/book.toml
sed -i 's/"ItalicFont=CoreSansA45It.ttf",//g' book/book.toml
sed -i 's/"BoldItalicFont=CoreSansA65It.ttf",//g' book/book.toml
sed -i 's/CoreSansA45.ttf/Open Sans:style=Regular/g' book/book.toml
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really too happy with this but it's the best way I found to fix this without massive refactorings

@hdoordt hdoordt merged commit c540242 into mainmatter:main Oct 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants