fix: refactor popover implementation with react-tiny-popover.
#1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comp0te
previously approved these changes
Jan 13, 2025
Comp0te
approved these changes
Jan 18, 2025
Comp0te
deleted the
WALLET-458-cw-three-dots-button-for-accounts-list-opens-window-far-from-selected-account
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure to fill in all the below sections.
Description
Replaced custom popover logic with
react-tiny-popoverfor improved code simplicity and maintainability. Updated components to use the new popover structure and added support for managing scroll behavior during popover visibility. Adjustedaccount-popoverandaccount-list-itemcomponents accordingly.Linked tickets
WALLET-458
Checklist
Make sure this PR title follows semantic release conventions: https://semantic-release.gitbook.io/semantic-release/#commit-message-format
If the PR adds any new text to the UI, make sure they are localized
Include a screenshot or recording if implementing significant UI or user flow change
When this PR affects architecture changes wait for review from Dmytro before merging
2025-01-13.12.43.10.mov