-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
here are a number of futher optimizations for the g3firmware #87
Open
craiglink
wants to merge
43
commits into
makerbot:master
Choose a base branch
from
craiglink:optimized
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t the interface buttons
…interupts for twi. add static debug message to out text to lcd screen
…interupts for twi. add static debug message to out text to lcd screen
…nd setDirection more explict to its behavior
…ough it isn't optimal
…eter of setValue in PinTmplt
clean up use of atomic_blocks and use them where they were needed and not where they weren't optimize the point setting and getting code to be significantly more efficient.
remove an unnecessary atomic block
add initial support for 16bit position values and commands modifiy runHostSlice to not return out of the middle of itself so that it could easily be wrapped by debug logic
…er the entire packet is built so that it can be done outside of an interrupt.
Phew. Ok, that is a pretty big stack of things. I'll try to dedicate some time to looking at this soon. Thanks for the awesome code! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
besides the various template optimization that I've already sent, I've done a number of further optimization in the firmware: