Feat: add grouped ilk emergency spells #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: oddaf <[email protected]>
amusingaxl
changed the title
amusingaxl
commented
Nov 25, 2024
amusingaxl
changed the title
oddaf
reviewed
Nov 28, 2024
Co-authored-by: oddaf <[email protected]>
oddaf
approved these changes
Nov 29, 2024
0xp3th1um
approved these changes
Dec 2, 2024
0xdecr1pto
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to remove the hard-coded ilks approach in favor of a more general one which allows us to specify the desired ilks in the constructor.
Regular spells are executed through a
delegatecallfromMCD_PAUSE_PROXY. For that reason, they usually should not have storage variables, as they'd be accessing and interacting withMCD_PAUSE_PROXY's storage, not their own.However, Emergency Spells are not required to interact with
MCD_PAUSEandMCD_PAUSE_PROXYat all. They execute actions through regularcallonMomcontracts, so we don't have this limitation.Even if the contract is somehow misused and used as a regular spell, interacting with
MCD_PAUSE, there wouldn't be a problem because the storage cannot be changed outside the constructor.This approach requires some amount of hacking due to some Solidity limitations (i.e.: no support for immutable arrays,bytes32 <-> stringconversion shenanigans).While there is still some code duplication,this is significantly reduced compared to the previous approach.