Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add deploy scripts #9

Merged
merged 9 commits into from
Nov 29, 2024
Merged

Feat: add deploy scripts #9

merged 9 commits into from
Nov 29, 2024

Conversation

amusingaxl
Copy link
Contributor

No description provided.

@amusingaxl amusingaxl requested a review from 0xp3th1um November 25, 2024 15:06
Farnoosh85

This comment was marked as spam.

Sign in to view

oddaf
oddaf reviewed Nov 26, 2024
View reviewed changes
script/MultiClipBreakerDeploy.s.sol Outdated Show resolved Hide resolved
script/MultiLineWipeDeploy.s.sol Outdated Show resolved Hide resolved
script/MultiOsmStopDeploy.s.sol Outdated Show resolved Hide resolved
script/SingleClipBreakerDeploy.s.sol Outdated Show resolved Hide resolved
script/SingleDdmDisableDeploy.s.sol Outdated Show resolved Hide resolved
script/SingleLineWipeDeploy.s.sol Outdated Show resolved Hide resolved
script/SingleLitePsmHaltDeploy.s.sol Outdated Show resolved Hide resolved
script/SingleOsmStopDeploy.s.sol Outdated Show resolved Hide resolved
script/SplitterStopDeploy.s.sol Outdated Show resolved Hide resolved
@oddaf
Copy link
Member

oddaf commented Nov 26, 2024 •
edited
Loading

All deployed contracts in the readme were:
a. Verified on Etherscan
b. Contain the correct collateral
c. Bytecode matches the version in the repository (commit f930860, latest reviewed in the Chainsecurity audit).

@makerdao makerdao deleted a comment from Farnoosh85 Nov 26, 2024
@amusingaxl amusingaxl requested a review from oddaf November 27, 2024 14:09
0xp3th1um
0xp3th1um approved these changes Nov 29, 2024
View reviewed changes
Copy link

@0xp3th1um 0xp3th1um left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
The deployed contracts and their bytecode on Etherscan were also verified against commit f930860 (Chainsecurity audit)

@amusingaxl amusingaxl merged commit 4e14e95 into master Nov 29, 2024
1 check passed
@amusingaxl amusingaxl deleted the feat/deploy-scripts branch November 29, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xp3th1um 0xp3th1um 0xp3th1um approved these changes

@oddaf oddaf oddaf approved these changes

@Farnoosh85 Farnoosh85 Farnoosh85 left review comments

@0xdecr1pto 0xdecr1pto Awaiting requested review from 0xdecr1pto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amusingaxl @oddaf @0xp3th1um @Farnoosh85