Refetch partial active polls if not found

makerdao · Jul 18, 2023 · 7fb59c5 · 7fb59c5
1 parent ba5724d
commit 7fb59c5
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/modules/polling/api/fetchPolls.ts b/modules/polling/api/fetchPolls.ts
@@ -275,21 +275,22 @@ export async function refetchPolls(
 export async function getActivePollIds(network: SupportedNetworks): Promise<number[]> {
   const { valid: cachedPollsAreValid, hash: githubHash } = await checkCachedPollsValidity(network);
 
-  let partialActivePolls: PartialActivePoll[] = [];
+  let partialActivePolls: PartialActivePoll[] | undefined;
 
   if (cachedPollsAreValid) {
     const cachedPartialActivePolls = await cacheGet(partialActivePollsCacheKey, network, ONE_WEEK_IN_MS);
     if (cachedPartialActivePolls) {
       partialActivePolls = JSON.parse(cachedPartialActivePolls);
     }
-  } else {
+  }
+
+  if (!partialActivePolls) {
     const { partialActivePolls: newPartialActivePolls } = await refetchPolls(network, githubHash as string);
     partialActivePolls = newPartialActivePolls;
   }
 
-  const activePollIds = partialActivePolls
-    .filter(poll => new Date(poll.endDate) > new Date())
-    .map(poll => poll.pollId);
+  const activePollIds =
+    partialActivePolls?.filter(poll => new Date(poll.endDate) > new Date()).map(poll => poll.pollId) || [];
 
   return activePollIds;
 }