Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active polls cache fix #804

Closed
wants to merge 2 commits into from
Closed

Active polls cache fix #804

wants to merge 2 commits into from

Conversation

hernandoagf
Copy link
Collaborator

What does this PR do?

It ensure the partial-active-polls are re-fetched if their cache key is not valid or not found

hernandoagf and others added 2 commits July 5, 2023 14:37
… page (#800)

* 0.11.2

* fix(polling): support for pollId when fetching polls (#797)

* better handle markdown in create page (#801)

* Backmerge master into develop (#799)

Co-authored-by: Phil Bain <[email protected]>

* Bump version to 0.11.3

---------

Co-authored-by: Adam Goth <[email protected]>
Co-authored-by: Tyler Sorensen <[email protected]>
Co-authored-by: Phil Bain <[email protected]>
@vercel
Copy link

vercel bot commented Jul 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
governance-portal-v2 ✅ Ready (Inspect) Visit Preview Jul 18, 2023 11:05pm

@what-the-diff
Copy link

what-the-diff bot commented Jul 18, 2023

PR Summary

  • Added a new parameter to the 'fetchSinglePoll' function
    The code now accepts an additional parameter, pollIdOrSlug, in the fetchSinglePoll function which is located in the fetchPollBy.ts file.

  • Improved Logic for Determining Poll's ID
    We've refined the way our code determines the Poll's ID. This is based on newly introduced pollIdOrSlug parameter in the fetchPollBy.ts file.

  • Refactoring Active Poll's Logic
    Updates to the fetchPolls.ts file include a better mechanism for assigning partialActivePolls and a more efficient way to filter the activePollIds array.

  • Updated Mobile Vote Sheet to enable passing of 'nextPollId'
    For a better user experience, we updated the Mobile Vote Sheet(MobileVoteSheet.tsx) to pass 'nextPollId' to the fetchSinglePoll function.

  • Package Version Update
    The version information in package.json has been updated to "0.11.3".

  • Passing additional Parameters in API calls
    The pollIdOrSlug parameter is now also passed to the fetchSinglePoll function in polling/[poll-id-or-slug].ts and polling/tally/[poll-id].ts files.

  • Code Optimization in Markdown Rendering
    In executive/create.tsx and polling/create.tsx, the rendered Markdown is now wrapped in the Box component to provide encapsulation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant