Check for presence of v1 delegate address #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l-v2 into check-delegate-v1
* Add byteron link * PBG and UPMaker
Check v1 delegate first
Add vigilant v2 contract
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
torhector2
previously approved these changes
Oct 29, 2024
b-pmcg
reviewed
Oct 29, 2024
Comment on lines
17
to
19
| const v1VoteDelegateAddress = await contracts.voteDelegateFactoryOld.delegates(address); | ||
| return v1VoteDelegateAddress !== ZERO_ADDRESS | ||
| ? v1VoteDelegateAddress |
There was a problem hiding this comment.
small thing, but can we call this voteDelegateAddressOld instead of v1VoteDelegateAddress to keep it consistent?
b-pmcg
previously approved these changes
Oct 29, 2024
torhector2
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.