Spell 2025-01-09 #446
Merged
Spell 2025-01-09 #446
+8,461
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SidestreamIcedMango
requested changes
Jan 8, 2025
oddaf
reviewed
Jan 9, 2025
SidestreamIcedMango
requested changes
Jan 9, 2025
src/DssSpell.sol
Outdated
Comment on lines
38
to
40
| interface SkyLike { | ||
| function transfer(address to, uint256 value) external returns (bool); | ||
| } |
There was a problem hiding this comment.
This is unused now, please remove it :)
|
Good to deploy Mainnet Executive Spell Review ChecklistDevelopment Stage
Pre-Deployment Stage
Exec Doc detailed instructionsProposal DetailsWBTC Oracle Migration
If this executive proposal passes, then the source of BTC/USD pricing for the WBTC Oracle Safety Module (OSM) will be updated to 0x24C392CDbF32Cf911B258981a66d5541d85269ce. This will update the price source to the new Chronicle Scribe-based design as documented in Atlas A.3.8.1.1.4. The relevant call for this action is: OsmAbstract(PIP_WBTC).change(0x24C392CDbF32Cf911B258981a66d5541d85269ce);ALLOCATOR-SPARK-A Maximum Debt Ceiling (
|
| Delegate | Amount (USDS) | Address |
|---|---|---|
| BLUE | 4,000 | 0xb6C09680D822F162449cdFB8248a7D3FC26Ec9Bf |
| Bonapublica | 4,000 | 0x167c1a762B08D7e78dbF8f24e5C3f1Ab415021D3 |
| Byteron | 533 | 0xc2982e72D060cab2387Dba96b846acb8c96EfF66 |
| Cloaky | 4,000 | 0x869b6d5d8FA7f4FFdaCA4D23FFE0735c5eD1F818 |
| JuliaChang | 4,000 | 0x252abAEe2F4f4b8D39E5F12b163eDFb7fac7AED7 |
| Rocky | 2,790 | 0xC31637BDA32a0811E39456A59022D2C386cb2C85 |
| vigilant | 4,000 | 0x2474937cB55500601BCCE9f4cb0A0A72Dc226F61 |
Atlas Core Development Payments for December 2024
- Authorization: Ecosystem Approval, Atlas Axis Approval
- Proposal: Forum Post
If this executive proposal passes, then a total of 126,438 USDS and 988,000 SKY will be distributed for Atlas Core Development funding.
USDS Payments
| Recipient | Amount (USDS) | Address |
|---|---|---|
| BLUE | 83,602 | 0xb6C09680D822F162449cdFB8248a7D3FC26Ec9Bf |
| Kohla | 10,000 | 0x73dFC091Ad77c03F2809204fCF03C0b9dccf8c7a |
| Ennoia | 10,000 | 0xA7364a1738D0bB7D1911318Ca3FB3779A8A58D7b |
| Cloaky | 22,836 | 0x869b6d5d8FA7f4FFdaCA4D23FFE0735c5eD1F818 |
SKY Payments
| Recipient | Amount (SKY) | Address |
|---|---|---|
| BLUE | 550,000 | 0xb6C09680D822F162449cdFB8248a7D3FC26Ec9Bf |
| Cloaky | 438,000 | 0x869b6d5d8FA7f4FFdaCA4D23FFE0735c5eD1F818 |
Spark Proxy Spell
If this executive proposal passes, then a Spark Proxy Spell will be executed at 0x7fb2967cDC6816Dc508f35C5A6CB035C8B6507Ec with the following contents.
- Office hours value in the Exec Doc matches the spell
- Sum of all payments in the Exec Doc matches the tests
- Exec Doc URL in the spell comment matches your Raw Exec Doc URL above
- Exec Doc URL in the spell comment refers to the https://github.com/makerdao/community repository
- Every action present in the spell code is present in the Exec Doc
- Every action in the Exec Doc is present in the spell code
- IF new commits are present in the spell
- Copy relevant checklist items from the above and redo them
- Ensure newly added code is covered by tests
- Check if chainlog needs to be updated
- Copy over and redo "Tests" section from the above
- Tests
- Ensure that the
DssExecLib.addressfile is not being modified by the spell PR - Check all CI tests are passing as at the latest commit
Insert most recent commit hash where CI was passing
68d3594 - Ensure every test function is declared as
public- IF the test needs to run, it MUST NOT have the
skippedmodifier; OTHERWISE, it MUST have theskippedmodifier
- IF the test needs to run, it MUST NOT have the
- Ensure each spell action has sufficient test coverage
List actions for which coverage was checked here- WBTC Oracle Migration:
testWBTC_OracleMigration - Increase ALLOCATOR-SPARK-A Maximum Debt Ceiling (line):
testGeneral - Integration Boost Funding:
testPayments - Bug Bounty Payouts:
testPayments - Resilience Research Project Application Funding:
testPayments - Aligned Delegate USDS Compensation:
testPayments - Atlas Core Development USDS Payments:
testPayments - Atlas Core Development SKY Payments:
testPayments - Trigger Spark Proxy Spell:
testSparkSpellIsExecuted
- WBTC Oracle Migration:
- Ensure that any other env variable does not affect execution of the tests (for example, by inspecting the output of
printenv | grep "FOUNDRY_\|DAPP_") - IF a new module is initialized via the spell, the tests must include
- Sanity checks of the constructor arguments
- Sanity checks of all values added/updated by the spell function
- End-to-end "happy path" interaction with the module
- Check all tests are passing locally using
make test- Ensure every test listed in the coverage item above is present in the logs and with the
[PASS]prefix.
- Ensure every test listed in the coverage item above is present in the logs and with the
- Ensure that the
_Insert your local test logs here_
./scripts/test-dssspell-forge.sh no-match="" match="" block=""
Using DssExecLib at: 0x8De6DDbCd5053d32292AAA0D2105A32d108484a6
[⠊] Compiling...
[⠔] Compiling 4 files with Solc 0.8.16
[⠒] Solc 0.8.16 finished in 5.52s
Compiler run successful!
Ran 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 4849726)
[PASS] testStarknetSpell() (gas: 2302)
Suite result: ok. 2 passed; 0 failed; 0 skipped; finished in 49.40s (45.92s CPU time)
Warning: the following cheatcode(s) are deprecated and will be removed in future versions:
revertTo(uint256): replaced by `revertToState`
snapshot(): replaced by `snapshotState`
Ran 40 tests for src/DssSpell.t.sol:DssSpellTest
[SKIP] testAllocatorIntegration() (gas: 0)
[SKIP] testBytecodeMatches() (gas: 0)
[PASS] testCastCost() (gas: 4715972)
[PASS] testCastOnTime() (gas: 4712572)
[SKIP] testChainlogIntegrity() (gas: 0)
[PASS] testChainlogValues() (gas: 14311820)
[SKIP] testCollateralIntegrations() (gas: 0)
[PASS] testContractSize() (gas: 15832)
[SKIP] testDaoResolutions() (gas: 0)
[PASS] testDeployCost() (gas: 2196524)
[SKIP] testEsmAuth() (gas: 0)
[PASS] testGeneral() (gas: 34191693)
[SKIP] testIlkClipper() (gas: 0)
[SKIP] testL2ArbitrumSpell() (gas: 0)
[SKIP] testL2OptimismSpell() (gas: 0)
[SKIP] testLerpSurplusBuffer() (gas: 0)
[PASS] testLitePSMs() (gas: 5637527)
[SKIP] testLockstakeIlkIntegration() (gas: 0)
[SKIP] testMedianReaders() (gas: 0)
[SKIP] testNewAuthorizations() (gas: 0)
[SKIP] testNewCronJobs() (gas: 0)
[PASS] testNextCastTime() (gas: 458229)
[SKIP] testOffboardings() (gas: 0)
[PASS] testOfficeHours() (gas: 498681)
[SKIP] testOracleList() (gas: 0)
[SKIP] testOsmReaders() (gas: 0)
[PASS] testPSMs() (gas: 6237392)
[PASS] testPayments() (gas: 5036184)
[SKIP] testRemoveChainlogValues() (gas: 0)
[PASS] testRevertIfNotScheduled() (gas: 17530)
[PASS] testSparkSpellIsExecuted() (gas: 4717340)
[PASS] testSplitter() (gas: 5266683)
[PASS] testSystemTokens() (gas: 6122580)
[PASS] testUseEta() (gas: 354764)
[SKIP] testVestDAI() (gas: 0)
[SKIP] testVestMKR() (gas: 0)
[SKIP] testVestSKY() (gas: 0)
[PASS] testWBTC_OracleMigration() (gas: 4785920)
[SKIP] testYankDAI() (gas: 0)
[SKIP] testYankMKR() (gas: 0)
Suite result: ok. 17 passed; 0 failed; 23 skipped; finished in 325.54s (780.62s CPU time)
Ran 2 test suites in 326.22s (374.94s CPU time): 19 tests passed, 0 failed, 23 skipped (42 total tests)
- IF all checks pass, make sure to include explicit "Good to deploy" comment
oddaf
reviewed
Jan 9, 2025
|
Good to deploy! Mainnet Executive Spell Review ChecklistDevelopment Stage
_Insert your local test logs here_
./scripts/test-dssspell-forge.sh no-match="" match="" block=""
Using DssExecLib at: 0x8De6DDbCd5053d32292AAA0D2105A32d108484a6
[⠊] Compiling...
[⠘] Compiling 4 files with Solc 0.8.16
[⠊] Solc 0.8.16 finished in 2.85s
Compiler run successful!
Ran 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 4877856)
[PASS] testStarknetSpell() (gas: 2302)
Suite result: ok. 2 passed; 0 failed; 0 skipped; finished in 63.95s (59.12s CPU time)
Warning: the following cheatcode(s) are deprecated and will be removed in future versions:
revertTo(uint256): replaced by `revertToState`
snapshot(): replaced by `snapshotState`
Ran 40 tests for src/DssSpell.t.sol:DssSpellTest
[SKIP] testAllocatorIntegration() (gas: 0)
[SKIP] testBytecodeMatches() (gas: 0)
[PASS] testCastCost() (gas: 4744102)
[PASS] testCastOnTime() (gas: 4740702)
[SKIP] testChainlogIntegrity() (gas: 0)
[PASS] testChainlogValues() (gas: 14346982)
[SKIP] testCollateralIntegrations() (gas: 0)
[PASS] testContractSize() (gas: 15832)
[SKIP] testDaoResolutions() (gas: 0)
[PASS] testDeployCost() (gas: 2196524)
[SKIP] testEsmAuth() (gas: 0)
[PASS] testGeneral() (gas: 34227517)
[SKIP] testIlkClipper() (gas: 0)
[SKIP] testL2ArbitrumSpell() (gas: 0)
[SKIP] testL2OptimismSpell() (gas: 0)
[SKIP] testLerpSurplusBuffer() (gas: 0)
[PASS] testLitePSMs() (gas: 5615378)
[SKIP] testLockstakeIlkIntegration() (gas: 0)
[SKIP] testMedianReaders() (gas: 0)
[SKIP] testNewAuthorizations() (gas: 0)
[SKIP] testNewCronJobs() (gas: 0)
[PASS] testNextCastTime() (gas: 458229)
[SKIP] testOffboardings() (gas: 0)
[PASS] testOfficeHours() (gas: 498087)
[SKIP] testOracleList() (gas: 0)
[SKIP] testOsmReaders() (gas: 0)
[PASS] testPSMs() (gas: 6265522)
[PASS] testPayments() (gas: 5064688)
[SKIP] testRemoveChainlogValues() (gas: 0)
[PASS] testRevertIfNotScheduled() (gas: 17530)
[PASS] testSparkSpellIsExecuted() (gas: 4745469)
[PASS] testSplitter() (gas: 5294812)
[PASS] testSystemTokens() (gas: 6150896)
[PASS] testUseEta() (gas: 354764)
[SKIP] testVestDAI() (gas: 0)
[SKIP] testVestMKR() (gas: 0)
[SKIP] testVestSKY() (gas: 0)
[PASS] testWBTC_OracleMigration() (gas: 4814050)
[SKIP] testYankDAI() (gas: 0)
[SKIP] testYankMKR() (gas: 0)
Suite result: ok. 17 passed; 0 failed; 23 skipped; finished in 385.40s (1049.24s CPU time)
Ran 2 test suites in 386.28s (449.35s CPU time): 19 tests passed, 0 failed, 23 skipped (42 total tests)Pre-Deployment Stage
|
|
Good to deploy: Pre-Deployment Stage
Exec Doc detailed instructionsProposal DetailsWBTC Oracle Migration
If this executive proposal passes, then the source of BTC/USD pricing for the WBTC Oracle Safety Module (OSM) will be updated to 0x24C392CDbF32Cf911B258981a66d5541d85269ce. This will update the price source to the new Chronicle Scribe-based design as documented in Atlas A.3.8.1.1.4. The relevant call for this action is: OsmAbstract(PIP_WBTC).change(0x24C392CDbF32Cf911B258981a66d5541d85269ce);ALLOCATOR-SPARK-A Maximum Debt Ceiling (
|
| Delegate | Amount (USDS) | Address |
|---|---|---|
| BLUE | 4,000 | 0xb6C09680D822F162449cdFB8248a7D3FC26Ec9Bf |
| Bonapublica | 4,000 | 0x167c1a762B08D7e78dbF8f24e5C3f1Ab415021D3 |
| Byteron | 533 | 0xc2982e72D060cab2387Dba96b846acb8c96EfF66 |
| Cloaky | 4,000 | 0x869b6d5d8FA7f4FFdaCA4D23FFE0735c5eD1F818 |
| JuliaChang | 4,000 | 0x252abAEe2F4f4b8D39E5F12b163eDFb7fac7AED7 |
| Rocky | 2,790 | 0xC31637BDA32a0811E39456A59022D2C386cb2C85 |
| vigilant | 4,000 | 0x2474937cB55500601BCCE9f4cb0A0A72Dc226F61 |
Atlas Core Development Payments for December 2024
- Authorization: Ecosystem Approval, Atlas Axis Approval
- Proposal: Forum Post
If this executive proposal passes, then a total of 126,438 USDS and 988,000 SKY will be distributed for Atlas Core Development funding.
USDS Payments
| Recipient | Amount (USDS) | Address |
|---|---|---|
| BLUE | 83,602 | 0xb6C09680D822F162449cdFB8248a7D3FC26Ec9Bf |
| Kohla | 10,000 | 0x73dFC091Ad77c03F2809204fCF03C0b9dccf8c7a |
| Ennoia | 10,000 | 0xA7364a1738D0bB7D1911318Ca3FB3779A8A58D7b |
| Cloaky | 22,836 | 0x869b6d5d8FA7f4FFdaCA4D23FFE0735c5eD1F818 |
SKY Payments
| Recipient | Amount (SKY) | Address |
|---|---|---|
| BLUE | 550,000 | 0xb6C09680D822F162449cdFB8248a7D3FC26Ec9Bf |
| Cloaky | 438,000 | 0x869b6d5d8FA7f4FFdaCA4D23FFE0735c5eD1F818 |
Spark Proxy Spell
If this executive proposal passes, then a Spark Proxy Spell will be executed at 0x7fb2967cDC6816Dc508f35C5A6CB035C8B6507Ec with the following contents.
- Office hours value in the Exec Doc matches the spell
- Sum of all payments in the Exec Doc matches the tests
- Exec Doc URL in the spell comment matches your Raw Exec Doc URL above
- Exec Doc URL in the spell comment refers to the https://github.com/makerdao/community repository
- Every action present in the spell code is present in the Exec Doc
- Every action in the Exec Doc is present in the spell code
- IF new commits are present in the spell
- Copy relevant checklist items from the above and redo them
- Ensure newly added code is covered by tests
- Check if chainlog needs to be updated
- Copy over and redo "Tests" section from the above
- Tests
- Ensure that the
DssExecLib.addressfile is not being modified by the spell PR - Check all CI tests are passing as at the latest commit
Insert most recent commit hash where CI was passing
487b988 - Ensure every test function is declared as
public- IF the test needs to run, it MUST NOT have the
skippedmodifier; OTHERWISE, it MUST have theskippedmodifier
- IF the test needs to run, it MUST NOT have the
- Ensure each spell action has sufficient test coverage
List actions for which coverage was checked here- WBTC Oracle Migration:
testWBTC_OracleMigration - Increase ALLOCATOR-SPARK-A Maximum Debt Ceiling (line):
testGeneral - Integration Boost Funding:
testPayments - Bug Bounty Payouts:
testPayments - Resilience Research Project Application Funding:
testPayments - Aligned Delegate USDS Compensation:
testPayments - Atlas Core Development USDS Payments:
testPayments - Atlas Core Development SKY Payments:
testPayments - Trigger Spark Proxy Spell:
testSparkSpellIsExecuted
- WBTC Oracle Migration:
- Ensure that any other env variable does not affect execution of the tests (for example, by inspecting the output of
printenv | grep "FOUNDRY_\|DAPP_") - IF a new module is initialized via the spell, the tests must include
- Sanity checks of the constructor arguments
- Sanity checks of all values added/updated by the spell function
- End-to-end "happy path" interaction with the module
- Check all tests are passing locally using
make test- Ensure every test listed in the coverage item above is present in the logs and with the
[PASS]prefix.
- Ensure every test listed in the coverage item above is present in the logs and with the
- Ensure that the
_Insert your local test logs here_
./scripts/test-dssspell-forge.sh no-match="" match="" block=""
Using DssExecLib at: 0x8De6DDbCd5053d32292AAA0D2105A32d108484a6
[⠊] Compiling...
No files changed, compilation skipped
Ran 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 4886112)
[PASS] testStarknetSpell() (gas: 2302)
Suite result: ok. 2 passed; 0 failed; 0 skipped; finished in 50.64s (47.07s CPU time)
Warning: the following cheatcode(s) are deprecated and will be removed in future versions:
revertTo(uint256): replaced by `revertToState`
snapshot(): replaced by `snapshotState`
Ran 40 tests for src/DssSpell.t.sol:DssSpellTest
[SKIP] testAllocatorIntegration() (gas: 0)
[SKIP] testBytecodeMatches() (gas: 0)
[PASS] testCastCost() (gas: 4752358)
[PASS] testCastOnTime() (gas: 4748958)
[SKIP] testChainlogIntegrity() (gas: 0)
[PASS] testChainlogValues() (gas: 14357302)
[SKIP] testCollateralIntegrations() (gas: 0)
[PASS] testContractSize() (gas: 15832)
[SKIP] testDaoResolutions() (gas: 0)
[PASS] testDeployCost() (gas: 2196524)
[SKIP] testEsmAuth() (gas: 0)
[PASS] testGeneral() (gas: 34237837)
[SKIP] testIlkClipper() (gas: 0)
[SKIP] testL2ArbitrumSpell() (gas: 0)
[SKIP] testL2OptimismSpell() (gas: 0)
[SKIP] testLerpSurplusBuffer() (gas: 0)
[PASS] testLitePSMs() (gas: 5623634)
[SKIP] testLockstakeIlkIntegration() (gas: 0)
[SKIP] testMedianReaders() (gas: 0)
[SKIP] testNewAuthorizations() (gas: 0)
[SKIP] testNewCronJobs() (gas: 0)
[PASS] testNextCastTime() (gas: 458229)
[SKIP] testOffboardings() (gas: 0)
[PASS] testOfficeHours() (gas: 498087)
[SKIP] testOracleList() (gas: 0)
[SKIP] testOsmReaders() (gas: 0)
[PASS] testPSMs() (gas: 6273778)
[PASS] testPayments() (gas: 5072852)
[SKIP] testRemoveChainlogValues() (gas: 0)
[PASS] testRevertIfNotScheduled() (gas: 17530)
[PASS] testSparkSpellIsExecuted() (gas: 4753725)
[PASS] testSplitter() (gas: 5303068)
[PASS] testSystemTokens() (gas: 6159152)
[PASS] testUseEta() (gas: 354764)
[SKIP] testVestDAI() (gas: 0)
[SKIP] testVestMKR() (gas: 0)
[SKIP] testVestSKY() (gas: 0)
[PASS] testWBTC_OracleMigration() (gas: 4822306)
[SKIP] testYankDAI() (gas: 0)
[SKIP] testYankMKR() (gas: 0)
Suite result: ok. 17 passed; 0 failed; 23 skipped; finished in 328.83s (790.39s CPU time)
Ran 2 test suites in 329.51s (379.47s CPU time): 19 tests passed, 0 failed, 23 skipped (42 total tests)
- IF all checks pass, make sure to include explicit "Good to deploy" comment
|
The spell is deployed at: https://etherscan.io/address/0x5985E06E47e0dd10230393e5dEF7200516262ed9 |
|
Good to handover: Deployed Stage
|
|
Good to handover :) Deployed Stage
_Insert your local test logs here_
./scripts/test-dssspell-forge.sh no-match="" match="" block=""
Using DssExecLib at: 0x8De6DDbCd5053d32292AAA0D2105A32d108484a6
[⠊] Compiling...
[⠊] Compiling 4 files with Solc 0.8.16
[⠒] Solc 0.8.16 finished in 5.07s
Compiler run successful!
Ran 2 tests for src/test/starknet.t.sol:StarknetTests
[PASS] testStarknet() (gas: 4952544)
[PASS] testStarknetSpell() (gas: 2302)
Suite result: ok. 2 passed; 0 failed; 0 skipped; finished in 63.09s (60.26s CPU time)
Warning: the following cheatcode(s) are deprecated and will be removed in future versions:
revertTo(uint256): replaced by `revertToState`
snapshot(): replaced by `snapshotState`
Ran 40 tests for src/DssSpell.t.sol:DssSpellTest
[SKIP] testAllocatorIntegration() (gas: 0)
[PASS] testBytecodeMatches() (gas: 2214691)
[PASS] testCastCost() (gas: 4818791)
[PASS] testCastOnTime() (gas: 4815391)
[SKIP] testChainlogIntegrity() (gas: 0)
[PASS] testChainlogValues() (gas: 14440343)
[SKIP] testCollateralIntegrations() (gas: 0)
[SKIP] testContractSize() (gas: 0)
[SKIP] testDaoResolutions() (gas: 0)
[SKIP] testDeployCost() (gas: 0)
[SKIP] testEsmAuth() (gas: 0)
[PASS] testGeneral() (gas: 34322975)
[SKIP] testIlkClipper() (gas: 0)
[SKIP] testL2ArbitrumSpell() (gas: 0)
[SKIP] testL2OptimismSpell() (gas: 0)
[SKIP] testLerpSurplusBuffer() (gas: 0)
[PASS] testLitePSMs() (gas: 5740345)
[SKIP] testLockstakeIlkIntegration() (gas: 0)
[SKIP] testMedianReaders() (gas: 0)
[SKIP] testNewAuthorizations() (gas: 0)
[SKIP] testNewCronJobs() (gas: 0)
[PASS] testNextCastTime() (gas: 458229)
[SKIP] testOffboardings() (gas: 0)
[PASS] testOfficeHours() (gas: 497372)
[SKIP] testOracleList() (gas: 0)
[SKIP] testOsmReaders() (gas: 0)
[PASS] testPSMs() (gas: 6340211)
[PASS] testPayments() (gas: 5139101)
[SKIP] testRemoveChainlogValues() (gas: 0)
[PASS] testRevertIfNotScheduled() (gas: 17530)
[PASS] testSparkSpellIsExecuted() (gas: 4820158)
[PASS] testSplitter() (gas: 5369501)
[PASS] testSystemTokens() (gas: 6225776)
[PASS] testUseEta() (gas: 354764)
[SKIP] testVestDAI() (gas: 0)
[SKIP] testVestMKR() (gas: 0)
[SKIP] testVestSKY() (gas: 0)
[PASS] testWBTC_OracleMigration() (gas: 4888739)
[SKIP] testYankDAI() (gas: 0)
[SKIP] testYankMKR() (gas: 0)
Suite result: ok. 16 passed; 0 failed; 24 skipped; finished in 390.40s (1085.79s CPU time)
Ran 2 test suites in 391.34s (453.50s CPU time): 18 tests passed, 0 failed, 24 skipped (42 total tests) |
oddaf
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Handover and Merge Stage
- Check that the spell address posted by the crafter in
new-spellsis correct - Confirm the address in the
new-spellschannel (via a separate "reply to" message, restating the address to avoid edits)- Wait until responsible governance facilitator confirms handover in
new-spells
- Wait until responsible governance facilitator confirms handover in
- Ensure that no changes were made to the code since the spell was deployed and archived
- Approve spell PR for merge via 'Approve' review option
SidestreamIcedMango
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Handover and Merge Stage
- Check that the spell address posted by the crafter in
new-spellsis correct - Confirm the address in the
new-spellschannel (via a separate "reply to" message, restating the address to avoid edits)- Wait until responsible governance facilitator confirms handover in
new-spells
- Wait until responsible governance facilitator confirms handover in
- Ensure that no changes were made to the code since the spell was deployed and archived
- Approve spell PR for merge via 'Approve' review option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contribution Checklist
(PE-<TICKET_NUMBER>)Checklist
officeHoursmodifier override30 daysunless otherwise specified)ETH_GAS_LIMIT="XXX" ETH_GAS_PRICE="YYY" make deploymainnetcontract on etherscanmake archive-spellormake date="YYYY-MM-DD" archive-spellto make an archive directory and copyDssSpell.sol,DssSpell.t.sol,DssSpell.t.base.sol, andDssSpellCollateralOnboarding.solsquash and mergethis PR