Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix add element on SelectMultipleWithProp widget #283

Merged

Conversation

TheoLechemia
Copy link
Contributor

@TheoLechemia TheoLechemia commented Dec 11, 2023

L'ajout des éléménts créés à la "volée" via le widget SelectMultipleWithPop ne fonctionnait plus.
Cette PR corrige ce bug

@TheoLechemia TheoLechemia marked this pull request as ready for review December 12, 2023 14:24
@camillemonchicourt
Copy link
Contributor

camillemonchicourt commented Dec 13, 2023

Fix GeotrekCE/Geotrek-admin#1299
Lié à GeotrekCE/Geotrek-admin#3587

Les liens web, et à terme les organisateurs des événements (+ d'autres champs à venir) peuvent être complétés directement depuis les formulaires des modules et les listes déroulantes des formulaires sont directement complétés avec l'objet ajouté sans recharger la page.

@submarcos
Copy link
Member

@TheoLechemia Merci. Une petite entrée dans le changelog serait bienvenue

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3f3a949) 89.26% compared to head (6c4f420) 89.26%.
Report is 4 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #283   +/-   ##
=======================================
  Coverage   89.26%   89.26%           
=======================================
  Files          32       32           
  Lines        2385     2385           
=======================================
  Hits         2129     2129           
  Misses        256      256           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheoLechemia
Copy link
Contributor Author

C'est fait

@TheoLechemia TheoLechemia force-pushed the feat/SelectMultipleWithPop branch from 8e14bda to 6c4f420 Compare December 21, 2023 10:15
@submarcos submarcos merged commit 126e279 into makinacorpus:master Feb 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants