Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure equivalence with upstream #49

Closed
shuhuiluo opened this issue Mar 2, 2024 · 4 comments · Fixed by #55
Closed

Ensure equivalence with upstream #49

shuhuiluo opened this issue Mar 2, 2024 · 4 comments · Fixed by #55
Assignees
@malik672

Comments

@shuhuiluo
Copy link
Collaborator

The addresses mod differs from the official TS SDK after recent upstream updates. For example the swap_router02_address function should be changed after Uniswap/sdk-core#120. Same for V2_FACTORY_ADDRESSES after Uniswap/sdk-core#115. Also V2_ROUTER_ADDRESSES was modified in Uniswap/sdk-core#113.
@shuhuiluo
Copy link
Collaborator Author

Also should use lazy statics for address maps instead of functions to keep naming the same.

@shuhuiluo
Copy link
Collaborator Author

And add tests as in Uniswap/sdk-core#120.

@malik672
Copy link
Owner

malik672 commented Mar 4, 2024

Also should use lazy statics for address maps instead of functions to keep naming the same.

or just make make it constants

@malik672
Copy link
Owner

malik672 commented Mar 4, 2024

And add tests as in Uniswap/sdk-core#120.

this is so funny, currently implementing it and it's failing all tests

@shuhuiluo shuhuiluo linked a pull request Mar 5, 2024 that will close this issue
fix(upstream): Fix discrepancy with upstream #55
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@malik672 malik672

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(upstream): Fix discrepancy with upstream malik672/uniswap-sdk-core-rust
2 participants
@malik672 @shuhuiluo