New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(upstream): Fix discrepancy with upstream #55

Merged

malik672 merged 19 commits into master from upstream

Mar 5, 2024

Owner

malik672 commented Mar 5, 2024

added upstream equivalence

malik672 added 11 commits

February 25, 2024 07:02


          new version

77b482e


          unmerged

0bd4f14


          changes

5f2d4ea


          new version

876621c


          solve issue 45

be18fb1


          solve issue 45


          remove lock

9e792d9


          changes

cbbe3b5


          added upstream equivalence

182b7a8


          added upstream equivalence

cb5bd69


          added upstream equivalence

556e9e0

malik672 requested a review from shuhuiluo

March 5, 2024 02:29


          add new version and removee cargo lock

5d80739

shuhuiluo requested changes

View reviewed changes

Collaborator

shuhuiluo left a comment

Missing V3_CORE_FACTORY_ADDRESSES,V3_MIGRATOR_ADDRESSES, etc.

src/addresses.rs Outdated Show resolved Hide resolved

src/addresses.rs Outdated Show resolved Hide resolved

src/addresses.rs Outdated Show resolved Hide resolved

src/addresses.rs Outdated Show resolved Hide resolved

src/addresses.rs Outdated Show resolved Hide resolved

src/addresses.rs Outdated Show resolved Hide resolved

src/addresses.rs Outdated Show resolved Hide resolved

src/addresses.rs Outdated Show resolved Hide resolved

src/addresses.rs Outdated Show resolved Hide resolved

src/addresses.rs Outdated Show resolved Hide resolved

shuhuiluo linked an issue

that may be closed by this pull request

Ensure equivalence with upstream #49

Closed

Owner Author

malik672 commented Mar 5, 2024

Missing V3_CORE_FACTORY_ADDRESSES,V3_MIGRATOR_ADDRESSES, etc.

can you drop the link to them

Collaborator

shuhuiluo commented Mar 5, 2024

Missing V3_CORE_FACTORY_ADDRESSES,V3_MIGRATOR_ADDRESSES, etc.

can you drop the link to them

https://github.com/Uniswap/sdk-core/blob/main/src/addresses.ts#L250

Owner Author

malik672 commented Mar 5, 2024 •

edited

Loading

didn't think i missed some parts

shuhuiluo requested changes

View reviewed changes

src/addresses.rs Show resolved Hide resolved


          fix issues

9ce0d28

malik672 force-pushed the upstream branch from ccb404d to 9ce0d28 Compare

March 5, 2024 07:13

malik672 requested a review from shuhuiluo

March 5, 2024 07:16

shuhuiluo requested changes

View reviewed changes

src/addresses.rs Outdated Show resolved Hide resolved

src/addresses.rs Outdated Show resolved Hide resolved

src/addresses.rs Outdated Show resolved Hide resolved

src/addresses.rs Outdated Show resolved Hide resolved

src/addresses.rs Outdated Show resolved Hide resolved

src/addresses.rs Outdated Show resolved Hide resolved

src/addresses.rs Outdated Show resolved Hide resolved

shuhuiluo changed the title ~~Upstream~~ fix(upstream): Fix discrepancy with upstream


          fixes

1e08f6b

malik672 requested a review from shuhuiluo

March 5, 2024 15:39


          fixes

7c7a8dd

Owner Author

malik672 commented Mar 5, 2024

@shuhuiluo check the failed test, can't discover the issue

shuhuiluo requested changes

View reviewed changes

Collaborator

shuhuiluo left a comment

Fix bigdecimal to 0.4.2 to fix the tests.

src/addresses.rs Outdated Show resolved Hide resolved

shuhuiluo requested changes

View reviewed changes

src/addresses.rs Outdated Show resolved Hide resolved

shuhuiluo requested changes

View reviewed changes

src/addresses.rs Outdated Show resolved Hide resolved

malik672 and others added 3 commits

March 5, 2024 17:32


          Update src/addresses.rs

d8021d4

Co-authored-by: Shuhui Luo <[email protected]>


          Update src/addresses.rs

47ad391

Co-authored-by: Shuhui Luo <[email protected]>


          Update src/addresses.rs

a97a306

Co-authored-by: Shuhui Luo <[email protected]>

malik672 requested a review from shuhuiluo

March 5, 2024 16:34

Owner Author

malik672 commented Mar 5, 2024 •

edited

Loading

a97a306
that's what it's currently at

Collaborator

shuhuiluo commented Mar 5, 2024

@shuhuiluo check the failed test, can't discover the issue

bigdecimal = "=0.4.2"


          Update Cargo.toml

acf1516

shuhuiluo approved these changes

View reviewed changes

Collaborator

shuhuiluo left a comment

Squash and merge.

malik672 merged commit 41108c1 into master

2 checks passed

malik672 deleted the upstream branch

March 5, 2024 16:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet