Improves mypy config. Adds explicit re-exports to __init__.py
.
#418
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mypy --strict
will complain if Chameleon does not have explicit re-exports, so as a good citizen of the typing ecosystem we should add them, other people should not have to ignore re-export errors on our behalf. Since the module structure of Chameleon is fairly simple, this shouldn't add any real maintenance burden, since the top-level__init__.py
file is the only one that re-exports imported symbols. We can also get rid of the flake8 per-file-ignores for__init__.py
this way.While I was at it I also increased the strictness of the strict config to match
mypy --strict
, as well as enabled most of the optional warnings. I also added some missing annotations while dealing with the newwarn-return-any
errors. Once everything is annotated and using the strict config, we can simplify most of the config back down to juststrict = true
.