Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't encode URLs for mamba env export --explicit #3745

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Jan 15, 2025

The URLs in the resulting explicit lockfile should ideally not be encoded, although they will not break Conda once conda/conda#14481 is released.

Reference: #3737, but this doesn't address the main issue there, which has to do with mamba create --json. This is instead about mamba env export --explicit

Test case:

micromamba env create --json --channel conda-forge --prefix=/tmp/x264 x264
micromamba env export --explicit --prefix=/tmp/x264

Note that no fix is necessary for mamba env export --json since there are no URLs in the output:

micromamba env export --json --prefix=/tmp/x264
{
  "channels": [
    "conda-forge"
  ],
  "dependencies": [
    "_libgcc_mutex=0.1=conda_forge",
    "_openmp_mutex=4.5=2_gnu",
    "libgcc=14.2.0=h77fa898_1",
    "libgcc-ng=14.2.0=h69a702a_1",
    "libgomp=14.2.0=h77fa898_1",
    "x264=1!164.3095=h166bdaf_2"
  ],
  "name": "",
  "prefix": "/tmp/x264"
}

The URLs in the resulting file should not be encoded.
@jjerphan jjerphan added the release::bug_fixes For PRs fixing bugs label Jan 15, 2025
@jjerphan jjerphan changed the title Don't encode URLs for mamba env export --explicit fix: Don't encode URLs for mamba env export --explicit Jan 24, 2025
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan jjerphan marked this pull request as ready for review January 24, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release::bug_fixes For PRs fixing bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants