Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3rdparty/ymfm: sync to latest #13263

Merged
merged 2 commits into from
Jan 30, 2025
Merged

3rdparty/ymfm: sync to latest #13263

merged 2 commits into from
Jan 30, 2025

Conversation

angelosa
Copy link
Member

@angelosa
Copy link
Member Author

This eventually goes after release. Need a base for pc98:roliroli detection bug later.
0141

@happppp
Copy link
Member

happppp commented Jan 23, 2025

ymfm_opx.h is a preliminary/placeholder file and won't compile. MAME has no need for it.

@angelosa
Copy link
Member Author

Ref: aaronsgiles/ymfm#64

@angelosa angelosa marked this pull request as draft January 24, 2025 23:54
@happppp
Copy link
Member

happppp commented Jan 25, 2025

Even if Aaron looks at that PR, this file is useless since there's no cpp file. So, no need to put this one on hold, I'd suggest just removing that h file.

@angelosa angelosa marked this pull request as ready for review January 30, 2025 10:53
@angelosa
Copy link
Member Author

Ready to merge after CI/CD passes.

@happppp happppp merged commit 5e41c0e into master Jan 30, 2025
10 checks passed
@happppp happppp deleted the ymfm-sync-2024 branch January 30, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants