Dynmically link openssl in vcpkg #1453
Conversation
| set(VCPKG_CMAKE_SYSTEM_NAME Linux) | ||
|
|
||
| if(${PORT} MATCHES "openssl") | ||
| set(VCPKG_LIBRARY_LINKAGE dynamic) |
There was a problem hiding this comment.
I'm wondering shouldn't we require dynamic linking to the standard library as well in this case?
There was a problem hiding this comment.
I think so but maybe not in the scope of this PR?
.github/workflows/build_steps.yml
Outdated
|
|
||
| - name: Install dynamically linked library for tests | ||
| if: matrix.os == 'linux' | ||
| run: yum install -y https://dl.fedoraproject.org/pub/epel/7/x86_64/Packages/o/openssl11-1.1.1k-7.el7.x86_64.rpm |
There was a problem hiding this comment.
Why install it when we're building it with vcpkg?
There was a problem hiding this comment.
Because the wheel no longer bundle withopenssl library. Platform which runs arcticdb now requires openssl manually installed.
|
The PR should be draft only for now as I am still testing the changes. Sorry for the time wasted on the review |
phoebusm
force-pushed
the
feature/openssl_dyn_linked_in_vcpkg
branch
from
c307aaa to
c4f9c4c
Compare
|
OpenSSL 1 is EOL so we can't require users to install it |
Will upgrade to openssl v3, which aligns with our conda build too |
phoebusm
force-pushed
the
feature/openssl_dyn_linked_in_vcpkg
branch
from
c4f9c4c to
cae6960
Compare
phoebusm
force-pushed
the
feature/openssl_dyn_linked_in_vcpkg
branch
from
0da5a76 to
cbba946
Compare
|
The plan of dynmically linking openssl in scrapped |
Reference Issues/PRs
What does this implement or fix?
Any other comments?
Checklist
Checklist for code changes...