Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for timestamps #70
Support for timestamps #70
Changes from 2 commits
f85ba70
423082e
425d68b
1e37716
5715cfd
05adbcc
62a5da0
3154eac
b906a45
7accf0a
2f961ef
0721e0c
e13ae41
411eb4c
5e883bb
a85ecaa
a554e0f
6a37966
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check notice on line 1 in include/sparrow/data_type.hpp
GitHub Actions / build
Run clang-format on include/sparrow/data_type.hpp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is one type missing before that one, see compare with the order of the enum,
BINARY
matchesstd::vector<byte_t>
but we dont have something forFIXED_SIZE_BINARY
. Not sure which type is missing though. @JohanMabille any idea what it would match?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
FIXED_SIZE_BINARY
is meant to be used for a fixed size binary type which is not a primitive type, in which case we could use astruct
as a type to testFIXED_SIZE_BINARY
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took the values from Arrow implementation, not sure which type this value should match.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, must we work on supporting
DATE32
andDATE64
which come beforeTIMESTAMP
?Edit: I guess we could support
TIMESTAMP
first if we were to have explicit integer identifiers for those types as introduced inarrow-cpp
with apache/arrow#37149 as proposed by 2f961efThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The support for DATE32 and DATE64 can be added later. Explicit integer identifiers would be required later for backward compatibility, but it doe snot matter for now, nor the enum "stability".