-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add lint/check to check extra dependency #2362 #2599
base: master
Are you sure you want to change the base?
Conversation
updated master branch
@williballenthin for now i have kept run to Warning instead of exit code 1(to pass the ci and also get debug files). Shall i change it to exit 1 or keep it in Warning only? Reference(artifcats .txt files) : https://github.com/mandiant/capa/actions/runs/13270649385/artifacts/2573886903 |
this should error out the CI run |
I have changed it to exit, but our master branch itself have many extra dependency which would conflict. Do we need to also remove it ? |
what extra dependencies did you find? |
91d21de
to
0e4fd4d
Compare
@williballenthin output data https://github.com/mandiant/capa/actions/runs/13290227487/artifacts/2579953653 diff.txt ->
|
@williballenthin all of the above dependency are expected packages. I have ignored them, but after numerous methods and tries > -e git+https://github.com/mandiant/capa@9aed266094a1e75258908d73802487b201c850f4#egg=flare_capa can't be ignored. |
Fixes #2362 (comment)
A check for extra packages during the installation of capa and its dependencies. This ensures that no unintended packages are installed.
[x] No CHANGELOG update needed
[x] No new tests needed
[x] No documentation update needed