Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lint/check to check extra dependency #2362 #2599

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

dhruvak001
Copy link
Contributor

Fixes #2362 (comment)

A check for extra packages during the installation of capa and its dependencies. This ensures that no unintended packages are installed.

[x] No CHANGELOG update needed
[x] No new tests needed
[x] No documentation update needed

@dhruvak001 dhruvak001 changed the title add lint/check to avoid missing entries in requirements.txt/pyproject.toml #2362 add lint/check to check extra dependency #2362 Feb 11, 2025
@dhruvak001
Copy link
Contributor Author

@williballenthin for now i have kept run to Warning instead of exit code 1(to pass the ci and also get debug files). Shall i change it to exit 1 or keep it in Warning only?

Reference(artifcats .txt files) : https://github.com/mandiant/capa/actions/runs/13270649385/artifacts/2573886903

@williballenthin
Copy link
Collaborator

this should error out the CI run

@dhruvak001
Copy link
Contributor Author

I have changed it to exit, but our master branch itself have many extra dependency which would conflict. Do we need to also remove it ?

@williballenthin
Copy link
Collaborator

what extra dependencies did you find?

@dhruvak001
Copy link
Contributor Author

dhruvak001 commented Feb 12, 2025

@williballenthin output data https://github.com/mandiant/capa/actions/runs/13290227487/artifacts/2579953653

diff.txt ->

0a1
-e git+https://github.com/mandiant/capa@63b7062f4d2689ba64e5ccee26d566668be018be#egg=flare_capa
2a4
altgraph==0.17.4
3a6
build==1.2.2
18c21,22
< pefile==2024.8.26
packaging==24.2
pefile==2023.2.7
25a30,32
pyinstaller-hooks-contrib==2025.1
pyinstaller==6.11.1
pyproject_hooks==1.2.0
26a34
pywin32-ctypes==0.2.3
31a40
tomli==2.2.1

@dhruvak001
Copy link
Contributor Author

@williballenthin all of the above dependency are expected packages. I have ignored them, but after numerous methods and tries > -e git+https://github.com/mandiant/capa@9aed266094a1e75258908d73802487b201c850f4#egg=flare_capa can't be ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add lint/check to avoid missing entries in requirements.txt/pyproject.toml
2 participants