Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Changes for release #80

Merged
merged 2 commits into from
Jan 12, 2025
Merged

Minor Changes for release #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba0f988
Minor Changes for release
mannprerak2 Jan 12, 2025
3268186
run formatter
mannprerak2 Jan 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 4.2.0

- Replace android callbacks to use event channel.

## 4.1.1

- Fix lints.
Expand Down
26 changes: 13 additions & 13 deletions android/src/main/java/com/pkmnapps/nearby_connections/NearbyConnectionsPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,18 +69,18 @@ public static void registerWith(Registrar registrar) {
pluginRegistrar = registrar;
channel = new MethodChannel(registrar.messenger(), "nearby_connections");
channel.setMethodCallHandler(new NearbyConnectionsPlugin(registrar.activity()));
// eventChannel=new EventChannel(flutterEngine.getDartExecutor().getBinaryMessenger(), "nearby_connections/events");
// eventChannel.setStreamHandler(
// new EventChannel.StreamHandler() {
// @Override
// public void onListen(Object arguments, EventChannel.EventSink events) {
// eventSink=events;
// }
// @Override
// public void onCancel(Object arguments) {
// eventSink=null;
// }
// });
eventChannel=new EventChannel(registrar.messenger(), "nearby_connections/events");
eventChannel.setStreamHandler(
new EventChannel.StreamHandler() {
@Override
public void onListen(Object arguments, EventChannel.EventSink events) {
eventSink=events;
}
@Override
public void onCancel(Object arguments) {
eventSink=null;
}
});
}

@Override
Expand Down Expand Up @@ -482,7 +482,7 @@ private Strategy getStrategy(int strategy) {
public void onAttachedToEngine(@NonNull FlutterPluginBinding binding) {
channel = new MethodChannel(binding.getBinaryMessenger(), "nearby_connections");
channel.setMethodCallHandler(this);
eventChannel=new EventChannel(binding.getFlutterEngine().getDartExecutor().getBinaryMessenger(), "nearby_connections/events");
eventChannel=new EventChannel(binding.getBinaryMessenger(), "nearby_connections/events");
eventChannel.setStreamHandler(
new EventChannel.StreamHandler() {
@Override
Expand Down
2 changes: 1 addition & 1 deletion example/android/gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.3-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.2-all.zip
2 changes: 1 addition & 1 deletion example/android/settings.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ pluginManagement {

plugins {
id "dev.flutter.flutter-plugin-loader" version "1.0.0"
id "com.android.application" version '7.4.2' apply false
id "com.android.application" version '8.2.1' apply false
id "org.jetbrains.kotlin.android" version "1.9.23" apply false
}

Expand Down
Loading
Loading