Fix for compilation error with flutter version 3.29 #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r, but FlutterJNI was detached from native C++. Could not send. Channel: nearby_connections. Response ID: 4 Refer from. https://medium.com/@gauravpaudel2013/tried-to-send-a-platform-message-to-flutter-but-flutterjni-was-detached-from-native-c-well-well-c7d9ccf0df96
…r, but FlutterJNI was detached from native C++. Could not send. Channel: nearby_connections. Response ID: 4 Refer from. https://medium.com/@gauravpaudel2013/tried-to-send-a-platform-message-to-flutter-but-flutterjni-was-detached-from-native-c-well-well-c7d9ccf0df96
…r, but FlutterJNI was detached from native C++. Could not send. Channel: nearby_connections. Response ID: 4 Refer from. https://medium.com/@gauravpaudel2013/tried-to-send-a-platform-message-to-flutter-but-flutterjni-was-detached-from-native-c-well-well-c7d9ccf0df96
…r, but FlutterJNI was detached from native C++. Could not send. Channel: nearby_connections. Response ID: 4 Refer from. https://medium.com/@gauravpaudel2013/tried-to-send-a-platform-message-to-flutter-but-flutterjni-was-detached-from-native-c-well-well-c7d9ccf0df96
…r, but FlutterJNI was detached from native C++. Could not send. Channel: nearby_connections. Response ID: 4 Refer from. https://medium.com/@gauravpaudel2013/tried-to-send-a-platform-message-to-flutter-but-flutterjni-was-detached-from-native-c-well-well-c7d9ccf0df96
…r, but FlutterJNI was detached from native C++. Could not send. Channel: nearby_connections. Response ID: 4 Refer from. https://medium.com/@gauravpaudel2013/tried-to-send-a-platform-message-to-flutter-but-flutterjni-was-detached-from-native-c-well-well-c7d9ccf0df96
…r, but FlutterJNI was detached from native C++. Could not send. Channel: nearby_connections. Response ID: 4 Refer from. https://medium.com/@gauravpaudel2013/tried-to-send-a-platform-message-to-flutter-but-flutterjni-was-detached-from-native-c-well-well-c7d9ccf0df96
…r, but FlutterJNI was detached from native C++. Could not send. Channel: nearby_connections. Response ID: 4 Refer from. https://medium.com/@gauravpaudel2013/tried-to-send-a-platform-message-to-flutter-but-flutterjni-was-detached-from-native-c-well-well-c7d9ccf0df96
…r, but FlutterJNI was detached from native C++. Could not send. Channel: nearby_connections. Response ID: 4 Refer from. https://medium.com/@gauravpaudel2013/tried-to-send-a-platform-message-to-flutter-but-flutterjni-was-detached-from-native-c-well-well-c7d9ccf0df96
…r, but FlutterJNI was detached from native C++. Could not send. Channel: nearby_connections. Response ID: 4 Refer from. https://medium.com/@gauravpaudel2013/tried-to-send-a-platform-message-to-flutter-but-flutterjni-was-detached-from-native-c-well-well-c7d9ccf0df96
…r, but FlutterJNI was detached from native C++. Could not send. Channel: nearby_connections. Response ID: 4 Refer from. https://medium.com/@gauravpaudel2013/tried-to-send-a-platform-message-to-flutter-but-flutterjni-was-detached-from-native-c-well-well-c7d9ccf0df96
…r, but FlutterJNI was detached from native C++. Could not send. Channel: nearby_connections. Response ID: 4 Refer from. https://medium.com/@gauravpaudel2013/tried-to-send-a-platform-message-to-flutter-but-flutterjni-was-detached-from-native-c-well-well-c7d9ccf0df96
…ConnectionsPlugin - Removed the legacy plugin registration method `registerWith` as it is no longer needed. - Removed unused `pluginRegistrar` variable. - Eliminated commented-out code related to method invocation within event callbacks for better readability. - Replaced the `//channel.invokeMethod` with `//` for readability in `onConnectionInitiated`, `onConnectionResult`, `onDisconnected`, `onPayloadReceived`, `onPayloadTransferUpdate`, `onEndpointFound`, and `onEndpointLost` callbacks.
rahulmaindargi
commented
Feb 19, 2025
lib/src/nearby.dart
Outdated
There was a problem hiding this comment.
Not sure why it is coming as a changed file.
I am unable to find a way to remove the file from Pull request, but its not required to fix compilation error
There was a problem hiding this comment.
you can try running git pull upstream release --no-rebase
then resolve the merge conflicts (use keep theirs)
# Conflicts: # android/src/main/java/com/pkmnapps/nearby_connections/NearbyConnectionsPlugin.java # lib/src/nearby.dart
|
u may wanna run |
This commit refactors the Dart code within the `Nearby` class to improve readability by aligning the code within the `receiveBroadcastStream` listener. Specifically, it ensures consistency by aligning the `case` statements and their corresponding code blocks.
|
Thanks @rahulmaindargi 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#83