Use thread pool for faster network IO #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetching package version info from PyPI can be much more faster by utilizing
multiprocessing.dummy
. Basically it's a wrapper aroundthreading
module which replicatesmultiprocessing
API. It provides a convenient means to concurrently instantiatepypiup.requirement.Requirement
objects which in turn make GET requests to PyPI. In short all code required for concurrent execution is only 4 lines:Another part is to make progressbar work correctly in a concurrent mode. I've rewrote progressbar handling code a bit to manually update it's state. Basically
click.progressbar
setup step requireslength
param instead ofiterable
andupdate
method should be called on bar each time we want to actually update it. To make sure thatbar.update
is called only afterRequirement
object instantiated and decouple this logic fromRequirement
class, I've implemented update functionality usingbarupdate
decorator which automatically callsbar.update
each time newRequirement
object created.Performance results
Below some results obtained by calculating time required for
pypiup.requirements.Requirements.read_file
execution: