GitHub issue handler #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a new model for a github issue containing the repo address and issue number.
jhaigh0
force-pushed
the
github_issue_handler
branch
2 times, most recently
from
9bd267d to
e896781
Compare
jhaigh0
force-pushed
the
github_issue_handler
branch
from
e896781 to
4dd35f9
Compare
robertapplin
suggested changes
May 7, 2024
Co-authored-by: Rob Applin <[email protected]>
thomashampson
requested changes
Jun 4, 2024
|
|
||
|
|
||
| class MatchingStackTraceSearchTest(TestCase): | ||
| entries = [ |
There was a problem hiding this comment.
I think the following would not be matched by the regex:
File "/opt/mantidworkbench6.9/lib/python3.10/site-packages/mantid/simpleapi.py", line 1083, in __call__
and also the following kind of thing that I found in the error reports slack channel:
Exception: MDWorkspace::getExperimentInfo(): expInfoIndex is out of range.
at line 152 in '/usr/local/anaconda/envs/mantid-dev/plugins/python/algorithms/ConvertWANDSCDtoQ.py'
| self.assertNotIn(username, _trim_stacktrace(test_trace)) | ||
|
|
||
| def test_line_trimmer_file_lines(self): | ||
| examples = { |
There was a problem hiding this comment.
you might want to add the above examples to this test too
jhaigh0
force-pushed
the
github_issue_handler
branch
from
65c000f to
dc9d5f2
Compare
thomashampson
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the main pr for "automatic github issue creation" of the Mantid error reporter improvements Epic.
What's been added:
GithubIssuecomprised of a repo address and an issue numbergithub_issue_manager.pywhich contains the main funcionget_or_create_github_issuewhich does the followingTwo new environment variables have been added
GIT_AUTH_TOKENis the auth token of the account used to create the github issues / comments (on the live version of the error reports site this will be an auth token from https://github.com/Mantid-Error-Reporter)GIT_ISSUE_REPOthe repository to create the issues in (e.g'ISISNeutronMuon/mantid-isis-support')I've also changed the slack message poster so that, id an issue is created / found, it'll be linked in the slack message.