-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ex01 exercise completed #92
Conversation
I have fixed the numpy issue by modifying the test workflow, however there is an Assertion Error:
Looking into it now! |
All tests for Ex_01 have passed! Will start working on Exercise 2 now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes made to pass python_tests
ex_02 has been completed with all checks passing.
|
363ce72
to
7a325b9
Compare
7a325b9
to
22ea60b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just need a few cleanups and tweaks.
All suggested changes have been made |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for changes.
Written as part of the Mantid New Starter exercises.