Publish nightly to pypi #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The update of Mantid 6.8 to 6.9 broke the nightly builds - Pinned mantid to previous 6.8 for now to fix it
- Changed name of conda publish action - Added action for PyPI publish - Changed workflow to deploy nightly to include PyPI package deployment - Changed versioning to match allowed formats by PyPI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work:
The main sentiment expressed by Matthew in #104 was that the use of the terminal should be as minimal as possible. With the changes to the CLI the part of using the terminal to create experiments is avoided but there was still another part of the problem missing. Namely the necessity of still having to activate a conda environment on the terminal every time an user wants to use mantid with the mvesuvio repository. Ideally Matthew doesn't touch the terminal on his daily use of the package.
The solution I came up with is to publish the package to PyPI nightly as we are currently doing with conda.
The reasons for this are the following:
./python -m pip install mvesuvioThe advantages of this approach is that users install mvesuvio only one time per mantid installation, using a single command. The disadvantage is of course that the CLI is not accessible via this installation. This will not be a problem due to the changes I have implemented in #105. These changes effectively mean that the user uses the default IP folder directory as the directory on their machine to store IP files. This is not a huge compromise as this directory is not meant to be changed anyway.
To test:
I will merge this to main (I know, I know) and check whether the nightly builds were successful 🤠