Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change github workflow to choose which tests to run #124

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

GuiMacielPereira
Copy link
Collaborator

@GuiMacielPereira GuiMacielPereira commented Jul 22, 2024

Description of work:

There were several changes in this commit:

  • The host for running the job changed from self-hosted to ubuntu-latest. This falls in line with the GitHub recommendation to use the default ubuntu-latest for non-private repos. The host was made self-hosted because before the system tests exceeded GitHub's limit. The running time was decreased in a previous commit so using ubuntu-latest is now a viable option.
  • Removed some unnecessary comments.
  • Added steps that check whether analysis or calibration files were changed using git diff. The result of the check is stored in environment variables analysis-changed and calibration-changed.
  • Calibration and analysis tests check the stored environment variables and run accordingly.

To test:

Look at the workflow actions and check that:

  • No tests were run in the first commit (no changes to analysis or calibration files)
  • The Analysis unit and system tests were triggered after changing analysis files
  • The Calibration unit and system tests were triggered after changing the calibration files

Fixes #90 .

There were several changes in this commit:

- The host for running the job changed from self-hosted to
  ubuntu-latest. This falls in line with the GitHub recommendation to
  use the default ubuntu-latest for non-private repos. The host was
  made self-hosted because before the system tests exceeded GitHub's
  limit. The running time was decreased in a previous commit so using
  ubuntu-latest is now a viable option.
- Removed some unnecessary comments.
- Added steps that check whether analysis or calibration files were
  changed using git diff. The result of the check is stored in
  environment variables analysis-changed and calibration-changed.
- Calibration and analysis tests check the stored environment variables
  and run accordingly.
Copy link
Collaborator

@SilkeSchomann SilkeSchomann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow file looks good and the different commits did trigger the correct tests (or none in the first case). 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Look into only running CI tests associated with the code changes
2 participants