Update benchmark for analysis system test #133
Merged
+11
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of defining a function for the numerical pseudo voigt function, we can just use scipy's voigt function, which is better defined and less prone to breaking.
Removed step that converted data to point data because workspace is already a point data workspace. So the original routine was passing data again to histogram which slightly shifts the correct position of the data.
Updated the benchmark by copying the outputs from the current sample_test.py.
Removed a step that would mask zeros as np.nan right before storing the results. This is not necessary anymore as the benchmark for the system tests is being updated in this PR. Updated the benchmark once again to match current state of vesuvio analysis.
Commiting a space to trigger correct tests on github. Ignore this commit.
GuiMacielPereira
assigned GuiMacielPereira and SilkeSchomann and unassigned GuiMacielPereira
SilkeSchomann
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work:
The system test for the analysis procedure was using a very old bench mark of results, which was storing the results of an antiquated version of the routine.
The routine should finally be updated and so the benchmark for the analysis system test should be updated too, because the difference in results is more than the tolerance that I had set.
To test:
Check that the analysis tests pass.